From patchwork Fri Oct 6 13:21:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 1844492 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=UkPejgKz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S28Hk0jXGz1yqD for ; Sat, 7 Oct 2023 00:22:56 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qokmR-000634-5S; Fri, 06 Oct 2023 09:22:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qokmD-0005vV-7N for qemu-devel@nongnu.org; Fri, 06 Oct 2023 09:22:01 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qokmB-00039S-4R for qemu-devel@nongnu.org; Fri, 06 Oct 2023 09:21:56 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1c60778a3bfso17088325ad.1 for ; Fri, 06 Oct 2023 06:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1696598512; x=1697203312; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CYrtWgCLjuFqK3RmFRFzS2KEs06tGcGYHPYhy2oGVUI=; b=UkPejgKzu0l0Yx0toS13WXd3wE/JEhy7D3GGqiMHeszY5x+uj6dBcRLLWTR/RrOkO7 +cIjVO37DVlrSps2vwlCmC9epEnUKcp4YDhOEVljFE5oFaIt2kk5PBPsssho3x7tCRYr sPd7kvPS+2e5JbyKR9YbWXNx/BkWa+ZGQS0pY952gyn93A2rHYAwkqhl5auFnlYzXawk 36lRqSEtcZQlmgzYfqvfmTkJnMB5TFJWXmmEdLJWW3z4k0CEIS8xApXSx9RAe64Kmp5J n35x/DstvMfDqDNAM0bFASfGVAvJxRO6e8hcBMVePduEIgyMdHLR7CggHcYnq/V3yB99 sO/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696598512; x=1697203312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CYrtWgCLjuFqK3RmFRFzS2KEs06tGcGYHPYhy2oGVUI=; b=JeWQq7RilMGq00hDtgv8Xc38FXYChLFEkSjGtBN+jlqgdDSJiILOlQIyKFdWyCCd+p z29pAO48oAbnHxOZ9Gkww0c9ptg1CcB9L8tu/WcjcSMiHY4dzuR0FsaOqaKGeN0K5rkF j9gXvdb+zLhoaEfgrmiExw2RrF1qVvKR9GTi9wOtd1AEOlunXkJ1bicAr3iBEXa6I9My DD2P0WD5l9LVYRRwXChGtIg/OtwTMTQAvWv7n9eaqRqM9qy1yJ3RBstR/DaOlorTEj1v V7Ryt/joqqdTf9MQNiwUMpsbCfM8YJaF4fn40F2x8DhQvdcrULp1F9iHKVgvOEOrcQFD +gzQ== X-Gm-Message-State: AOJu0YxxGLMvpv51+Z32Gmr+nujFaId3/oA2tdS4Yh2+Mwo8s4aeMqdF MpGuhfskeSwxmZ0/2b0frS5clGet3ub39nYiV3c= X-Google-Smtp-Source: AGHT+IEOgbMCTfZ9XPgmSRJCClN+KXwcn9ZvK1QY0n80DqJN11EhaQFcMQnrgeVThD22BZzFR7nSew== X-Received: by 2002:a17:902:d349:b0:1c5:e527:68b0 with SMTP id l9-20020a170902d34900b001c5e52768b0mr8051272plk.62.1696598512680; Fri, 06 Oct 2023 06:21:52 -0700 (PDT) Received: from grind.. ([177.94.42.196]) by smtp.gmail.com with ESMTPSA id c12-20020a170902c1cc00b001c60a548331sm3796669plc.304.2023.10.06.06.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 06:21:52 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, Daniel Henrique Barboza Subject: [PATCH v2 04/10] target/riscv/kvm: add 'rva22u64' flag as unavailable Date: Fri, 6 Oct 2023 10:21:28 -0300 Message-ID: <20231006132134.1135297-5-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231006132134.1135297-1-dbarboza@ventanamicro.com> References: <20231006132134.1135297-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org KVM does not have the means to support enabling the rva22u64 profile. The main reasons are: - we're missing support for some mandatory rva22u64 extensions in the KVM module; - we can't make promises about enabling a profile since it all depends on host support in the end. We'll revisit this decision in the future if needed. For now mark the 'rva22u64' profile as unavailable when running a KVM CPU: $ qemu-system-riscv64 -machine virt,accel=kvm -cpu rv64,rva22u64=true qemu-system-riscv64: can't apply global rv64-riscv-cpu.rva22u64=true: 'rva22u64' is not available with KVM Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- target/riscv/kvm/kvm-cpu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index c6615cb807..5f563b83df 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -358,7 +358,7 @@ static void cpu_set_cfg_unavailable(Object *obj, Visitor *v, } if (value) { - error_setg(errp, "extension %s is not available with KVM", + error_setg(errp, "'%s' is not available with KVM", propname); } } @@ -438,6 +438,11 @@ static void kvm_riscv_add_cpu_user_properties(Object *cpu_obj) riscv_cpu_add_kvm_unavail_prop_array(cpu_obj, riscv_cpu_extensions); riscv_cpu_add_kvm_unavail_prop_array(cpu_obj, riscv_cpu_vendor_exts); riscv_cpu_add_kvm_unavail_prop_array(cpu_obj, riscv_cpu_experimental_exts); + + /* We don't have the needed KVM support for profiles */ + for (i = 0; riscv_profiles[i] != NULL; i++) { + riscv_cpu_add_kvm_unavail_prop(cpu_obj, riscv_profiles[i]->name); + } } static int kvm_riscv_get_regs_core(CPUState *cs)