From patchwork Fri Oct 6 09:05:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "nicolas.eder@lauterbach.com" X-Patchwork-Id: 1844305 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S22gV334Sz20Vp for ; Fri, 6 Oct 2023 20:09:42 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qognY-0008Gp-Jd; Fri, 06 Oct 2023 05:07:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qognL-0008AB-9W for qemu-devel@nongnu.org; Fri, 06 Oct 2023 05:06:52 -0400 Received: from smtp1.lauterbach.com ([62.154.241.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qognJ-0000z9-FM for qemu-devel@nongnu.org; Fri, 06 Oct 2023 05:06:50 -0400 Received: (qmail 19743 invoked by uid 484); 6 Oct 2023 09:06:37 -0000 X-Qmail-Scanner-Diagnostics: from nedpc1.intern.lauterbach.com by smtp1.lauterbach.com (envelope-from , uid 484) with qmail-scanner-2.11 (mhr: 1.0. clamdscan: 0.99/21437. spamassassin: 3.4.0. Clear:RC:1(10.2.11.92):. Processed in 0.143277 secs); 06 Oct 2023 09:06:37 -0000 Received: from nedpc1.intern.lauterbach.com (Authenticated_SSL:neder@[10.2.11.92]) (envelope-sender ) by smtp1.lauterbach.com (qmail-ldap-1.03) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 6 Oct 2023 09:06:35 -0000 From: Nicolas Eder To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Christian.Boenig@lauterbach.com, =?utf-8?q?Alex_Benn=C3=A9e?= , Nicolas Eder Subject: [PATCH v2 16/29] deleting the mcdd startup option Date: Fri, 6 Oct 2023 11:05:57 +0200 Message-Id: <20231006090610.26171-17-nicolas.eder@lauterbach.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231006090610.26171-1-nicolas.eder@lauterbach.com> References: <20231006090610.26171-1-nicolas.eder@lauterbach.com> MIME-Version: 1.0 X-Qmail-Scanner-2.11: added fake Content-Type header Received-SPF: pass client-ip=62.154.241.196; envelope-from=nicolas.eder@lauterbach.com; helo=smtp1.lauterbach.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: neder Signed-off-by: neder --- mcdstub/meson.build | 10 +--------- qemu-options.hx | 13 +++---------- 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/mcdstub/meson.build b/mcdstub/meson.build index ebd47b0725..6b2f970eae 100644 --- a/mcdstub/meson.build +++ b/mcdstub/meson.build @@ -1,16 +1,9 @@ -# -# The main gdbstub still relies on per-build definitions of various -# types. The bits pushed to softmmu/user.c try to use guest agnostic -# types such as hwaddr. -# - # We need to build the core mcd code via a library to be able to tweak # cflags so: mcd_system_ss = ss.source_set() -# We build one version of the mcdstub, -#because it only needs to work for system emulation +# only system emulation is supported over mcd mcd_system_ss.add(files('mcdstub.c')) mcd_system_ss = mcd_system_ss.apply(config_host, strict: false) @@ -23,5 +16,4 @@ libmcd_softmmu = static_library('mcd_softmmu', mcd_softmmu = declare_dependency(link_whole: libmcd_softmmu) system_ss.add(mcd_softmmu) -# this might cause problems because we don't support user mode common_ss.add(files('mcd_syscalls.c')) diff --git a/qemu-options.hx b/qemu-options.hx index 0c15125b92..0b72c2de07 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4417,7 +4417,8 @@ ERST DEF("mcd", HAS_ARG, QEMU_OPTION_mcd, \ "-mcd dev accept mcd connection on 'dev'. (QEMU defaults to starting\n" " the guest without waiting for a mcd client to connect; use -S too\n" - " if you want it to not start execution.)\n", + " if you want it to not start execution.)\n" + " To use the default Port write '-mcd default'\n", QEMU_ARCH_ALL) SRST ``-mcd dev`` @@ -4428,15 +4429,7 @@ SRST The most usual configuration is to listen on a local TCP socket:: - -mcd tcp::1234 -ERST - -DEF("mcdd", 0, QEMU_OPTION_mcdd, \ - "-mcdd shorthand for -mcd tcp::" DEFAULT_MCDSTUB_PORT "\n", - QEMU_ARCH_ALL) -SRST -``-mcdd`` - Shorthand for -mcd tcp::1234, i.e. open a mcdserver on TCP port 1234 + -mcd tcp::1235 ERST DEF("d", HAS_ARG, QEMU_OPTION_d, \