diff mbox series

util/log: re-allow switching away from stderr log file

Message ID 20231004124446.491481-1-f.ebner@proxmox.com
State New
Headers show
Series util/log: re-allow switching away from stderr log file | expand

Commit Message

Fiona Ebner Oct. 4, 2023, 12:44 p.m. UTC 
Commit 59bde21374 ("util/log: do not close and reopen log files when
flags are turned off") prevented switching away from stderr on a
subsequent invocation of qemu_set_log_internal(). This prevented
switching away from stderr with the 'logfile' monitor command as well
as an invocation like
> ./qemu-system-x86_64 -trace 'qemu_mutex_lock,file=log'
from opening the specified log file.

Fixes: 59bde21374 ("util/log: do not close and reopen log files when flags are turned off")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 util/log.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Paolo Bonzini Oct. 4, 2023, 1:17 p.m. UTC | #1 
Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/util/log.c b/util/log.c
index def88a9402..d36c98da0b 100644
--- a/util/log.c
+++ b/util/log.c
@@ -298,6 +298,8 @@  static bool qemu_set_log_internal(const char *filename, bool changed_name,
             r->fd = logfile;
             qatomic_rcu_set(&global_file, NULL);
             call_rcu(r, rcu_close_file, rcu);
+        }
+        if (changed_name) {
             logfile = NULL;
         }
     }