mbox

[PULL,0/2] hex queue

Message ID 20231004004806.1461248-1-bcain@quicinc.com
State New
Headers show

Pull-request

https://github.com/quic/qemu tags/pull-hex-20231003

Message

Brian Cain Oct. 4, 2023, 12:48 a.m. UTC
The following changes since commit 36e9aab3c569d4c9ad780473596e18479838d1aa:

  migration: Move return path cleanup to main migration thread (2023-09-27 13:58:02 -0400)

are available in the Git repository at:

  https://github.com/quic/qemu tags/pull-hex-20231003

for you to fetch changes up to 53cdd26f1909fc45ad50a5eaa95dcfff06130e5f:

  target/hexagon: fix some occurrences of -Wshadow=local (2023-10-03 17:02:29 -0700)

----------------------------------------------------------------
Hexagon GETPC() and -Wshadow fixes

----------------------------------------------------------------
Brian Cain (1):
      target/hexagon: fix some occurrences of -Wshadow=local

Matheus Tavares Bernardino (1):
      target/hexagon: move GETPC() calls to top level helpers

 target/hexagon/imported/alu.idef |  6 +--
 target/hexagon/macros.h          | 19 +++++----
 target/hexagon/mmvec/macros.h    |  2 +-
 target/hexagon/op_helper.c       | 84 +++++++++++++++-------------------------
 target/hexagon/op_helper.h       |  9 -----
 target/hexagon/translate.c       | 10 ++---
 6 files changed, 50 insertions(+), 80 deletions(-)

Comments

Markus Armbruster Oct. 4, 2023, 7:38 a.m. UTC | #1
Looks like these patches haven't been posted to the list for (public)
review.  Needs to happen before a pull request.

Brian Cain <bcain@quicinc.com> writes:

> The following changes since commit 36e9aab3c569d4c9ad780473596e18479838d1aa:
>
>   migration: Move return path cleanup to main migration thread (2023-09-27 13:58:02 -0400)
>
> are available in the Git repository at:
>
>   https://github.com/quic/qemu tags/pull-hex-20231003
>
> for you to fetch changes up to 53cdd26f1909fc45ad50a5eaa95dcfff06130e5f:
>
>   target/hexagon: fix some occurrences of -Wshadow=local (2023-10-03 17:02:29 -0700)
>
> ----------------------------------------------------------------
> Hexagon GETPC() and -Wshadow fixes
>
> ----------------------------------------------------------------
> Brian Cain (1):
>       target/hexagon: fix some occurrences of -Wshadow=local
>
> Matheus Tavares Bernardino (1):
>       target/hexagon: move GETPC() calls to top level helpers
>
>  target/hexagon/imported/alu.idef |  6 +--
>  target/hexagon/macros.h          | 19 +++++----
>  target/hexagon/mmvec/macros.h    |  2 +-
>  target/hexagon/op_helper.c       | 84 +++++++++++++++-------------------------
>  target/hexagon/op_helper.h       |  9 -----
>  target/hexagon/translate.c       | 10 ++---
>  6 files changed, 50 insertions(+), 80 deletions(-)
Brian Cain Oct. 4, 2023, 12:41 p.m. UTC | #2
> -----Original Message-----
> From: Markus Armbruster <armbru@redhat.com>
> Sent: Wednesday, October 4, 2023 2:38 AM
> To: Brian Cain <bcain@quicinc.com>
> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
> philmd@linaro.org; peter.maydell@linaro.org; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; stefanha@redhat.com; ale@rev.ng;
> anjo@rev.ng; Marco Liebel (QUIC) <quic_mliebel@quicinc.com>;
> ltaylorsimpson@gmail.com
> Subject: Re: [PULL 0/2] hex queue
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
> 
> Looks like these patches haven't been posted to the list for (public)
> review.  Needs to happen before a pull request.

I'm sorry -- that was careless.  Matheus' patch had been but mine had not.

I've sent Matheus and my patches to the list for review only just now.

-Brian
Markus Armbruster Oct. 5, 2023, 6:02 a.m. UTC | #3
Brian Cain <bcain@quicinc.com> writes:

>> -----Original Message-----
>> From: Markus Armbruster <armbru@redhat.com>
>> Sent: Wednesday, October 4, 2023 2:38 AM
>> To: Brian Cain <bcain@quicinc.com>
>> Cc: qemu-devel@nongnu.org; richard.henderson@linaro.org;
>> philmd@linaro.org; peter.maydell@linaro.org; Matheus Bernardino (QUIC)
>> <quic_mathbern@quicinc.com>; stefanha@redhat.com; ale@rev.ng;
>> anjo@rev.ng; Marco Liebel (QUIC) <quic_mliebel@quicinc.com>;
>> ltaylorsimpson@gmail.com
>> Subject: Re: [PULL 0/2] hex queue
>> 
>> WARNING: This email originated from outside of Qualcomm. Please be wary of
>> any links or attachments, and do not enable macros.
>> 
>> Looks like these patches haven't been posted to the list for (public)
>> review.  Needs to happen before a pull request.
>
> I'm sorry -- that was careless.  Matheus' patch had been but mine had not.
>
> I've sent Matheus and my patches to the list for review only just now.

Thanks!