diff mbox series

[PULL,12/56] target/m68k: Clean up local variable shadowing

Message ID	20230929085053.2789105-13-armbru@redhat.com
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: Markus Armbruster <armbru@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, Peter Maydell <peter.maydell@linaro.org> Subject: [PULL 12/56] target/m68k: Clean up local variable shadowing Date: Fri, 29 Sep 2023 10:50:09 +0200 Message-ID: <20230929085053.2789105-13-armbru@redhat.com> In-Reply-To: <20230929085053.2789105-1-armbru@redhat.com> References: <20230929085053.2789105-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Series	[PULL,01/56] migration/rdma: Fix save_page method to fail on polling error \| expand [PULL,01/56] migration/rdma: Fix save_page method to fail on polling error [PULL,02/56] migration: Clean up local variable shadowing [PULL,03/56] ui: Clean up local variable shadowing [PULL,04/56] block/dirty-bitmap: Clean up local variable shadowing [PULL,05/56] block/vdi: Clean up local variable shadowing [PULL,06/56] block: Clean up local variable shadowing [PULL,07/56] qobject atomics osdep: Make a few macros more hygienic [PULL,08/56] tcg: Clean up local variable shadowing [PULL,09/56] target/arm/tcg: Clean up local variable shadowing [PULL,10/56] target/arm/hvf: Clean up local variable shadowing [PULL,11/56] target/mips: Clean up local variable shadowing [PULL,12/56] target/m68k: Clean up local variable shadowing [PULL,13/56] target/tricore: Clean up local variable shadowing [PULL,14/56] hw/arm/armv7m: Clean up local variable shadowing [PULL,15/56] hw/arm/virt: Clean up local variable shadowing [PULL,16/56] hw/arm/allwinner: Clean up local variable shadowing [PULL,17/56] hw/m68k: Clean up local variable shadowing [PULL,18/56] hw/microblaze: Clean up local variable shadowing [PULL,19/56] hw/nios2: Clean up local variable shadowing [PULL,20/56] net/eth: Clean up local variable shadowing [PULL,21/56] crypto/cipher-gnutls.c: Clean up local variable shadowing [PULL,22/56] util/vhost-user-server: Clean up local variable shadowing [PULL,23/56] linux-user/strace: Clean up local variable shadowing [PULL,24/56] sysemu/device_tree: Clean up local variable shadowing [PULL,25/56] softmmu/memory: Clean up local variable shadowing [PULL,26/56] softmmu/physmem: Clean up local variable shadowing [PULL,27/56] hw/core/machine: Clean up local variable shadowing [PULL,28/56] hw/intc/openpic: Clean up local variable shadowing [PULL,29/56] hw/ppc: Clean up local variable shadowing in _FDT helper routine [PULL,30/56] pnv/psi: Clean up local variable shadowing [PULL,31/56] spapr: Clean up local variable shadowing in spapr_dt_cpus() [PULL,32/56] spapr: Clean up local variable shadowing in spapr_init_cpus() [PULL,33/56] spapr: Clean up local variable shadowing in spapr_get_fw_dev_path() [PULL,34/56] spapr/drc: Clean up local variable shadowing in rtas_ibm_configure_connector() [PULL,35/56] spapr/pci: Clean up local variable shadowing in spapr_phb_realize() [PULL,36/56] spapr/drc: Clean up local variable shadowing in prop_get_fdt() [PULL,37/56] test-throttle: don't shadow 'index' variable in do_test_accounting() [PULL,38/56] hw/acpi: changes towards enabling -Wshadow=local [PULL,39/56] hw/intc/arm_gicv3_its: Avoid shadowing variable in do_process_its_cmd() [PULL,40/56] hw/misc/arm_sysctl.c: Avoid shadowing local variable [PULL,41/56] hw/arm/smmuv3.c: Avoid shadowing variable [PULL,42/56] hw/arm/smmuv3-internal.h: Don't use locals in statement macros [PULL,43/56] aspeed/i2c: Clean up local variable shadowing [PULL,44/56] aspeed: Clean up local variable shadowing [PULL,45/56] aspeed/i3c: Rename variable shadowing a local [PULL,46/56] aspeed/timer: Clean up local variable shadowing [PULL,47/56] intel_iommu: Fix shadow local variables on "size" [PULL,48/56] crypto: remove shadowed 'ret' variable [PULL,49/56] seccomp: avoid shadowing of 'action' variable [PULL,50/56] qemu-nbd: changes towards enabling -Wshadow=local [PULL,51/56] hw/riscv: opentitan: Fixup local variables shadowing [PULL,52/56] target/riscv: cpu: Fixup local variables shadowing [PULL,53/56] target/riscv: vector_helper: Fixup local variables shadowing [PULL,54/56] softmmu/device_tree: Fixup local variables shadowing [PULL,55/56] hw/nvme: Clean up local variable shadowing in nvme_ns_init() [PULL,56/56] disas/m68k: clean up local variable shadowing

Commit Message

Markus Armbruster Sept. 29, 2023, 8:50 a.m. UTC

From: Philippe Mathieu-Daudé <philmd@linaro.org>

Fix:

  target/m68k/translate.c:828:18: error: declaration shadows a local variable [-Werror,-Wshadow]
            TCGv tmp = tcg_temp_new();
                 ^
  target/m68k/translate.c:801:15: note: previous declaration is here
    TCGv reg, tmp, result;
              ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <20230904161235.84651-6-philmd@linaro.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 target/m68k/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 9e224fe796..15c9ddf427 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -824,7 +824,7 @@  static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0,
         reg = get_areg(s, reg0);
         result = gen_ldst(s, opsize, reg, val, what, index);
         if (what == EA_STORE || !addrp) {
-            TCGv tmp = tcg_temp_new();
+            tmp = tcg_temp_new();
             if (reg0 == 7 && opsize == OS_BYTE &&
                 m68k_feature(s->env, M68K_FEATURE_M68K)) {
                 tcg_gen_addi_i32(tmp, reg, 2);