| Message ID | 20230929000831.691559-1-crauer@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] tests/qtest: Fix npcm7xx_timer-test.c flaky test | expand |
On 29/09/2023 02.08, Chris Rauer wrote: > npcm7xx_timer-test occasionally fails due to the state of the timers > from the previous test iteration. Advancing the clock step after the > reset resolves this issue. > > Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897 > Signed-off-by: Chris Rauer <crauer@google.com> > --- > tests/qtest/npcm7xx_timer-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c > index 43711049ca..58f58c2f71 100644 > --- a/tests/qtest/npcm7xx_timer-test.c > +++ b/tests/qtest/npcm7xx_timer-test.c > @@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data) > int i; > > tim_reset(td); > + clock_step_next(); > > tim_write_ticr(td, count); > tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps)); Thanks! I'll queue it for my next pull request. Acked-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c index 43711049ca..58f58c2f71 100644 --- a/tests/qtest/npcm7xx_timer-test.c +++ b/tests/qtest/npcm7xx_timer-test.c @@ -465,6 +465,7 @@ static void test_periodic_interrupt(gconstpointer test_data) int i; tim_reset(td); + clock_step_next(); tim_write_ticr(td, count); tim_write_tcsr(td, CEN | IE | MODE_PERIODIC | PRESCALE(ps));
npcm7xx_timer-test occasionally fails due to the state of the timers from the previous test iteration. Advancing the clock step after the reset resolves this issue. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1897 Signed-off-by: Chris Rauer <crauer@google.com> --- tests/qtest/npcm7xx_timer-test.c | 1 + 1 file changed, 1 insertion(+)