From patchwork Thu Sep 7 12:59:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 1830864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YvpQZgVT; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RhKBD6V27z1ygc for ; Thu, 7 Sep 2023 23:01:24 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeEdA-0002sT-Lq; Thu, 07 Sep 2023 09:01:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeEcn-0002kx-Gf for qemu-devel@nongnu.org; Thu, 07 Sep 2023 09:00:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeEck-0007FV-Qb for qemu-devel@nongnu.org; Thu, 07 Sep 2023 09:00:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694091642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UW0LYVBQ86z9c2cV3F6pmV9ZwvsvlDsGKOMCu7v7vrc=; b=YvpQZgVTXW1NZgsm0/e4m4Lvw8n9fWfskyIR3v0bQitpcb07bWi5aGui4e+hiGQDYdwFXR jYxxAvhMJ6KZuZvegql6sSkicrY+hrSpCUr/ZqJ+80XOdzZqwSQmb1mAOhEtG66gNAlVQL srhHXMmrIFF3KnG6Y73nGBmEIRCUWzE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-INjB6wiPNimZNdnkT1x8EA-1; Thu, 07 Sep 2023 09:00:39 -0400 X-MC-Unique: INjB6wiPNimZNdnkT1x8EA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-402493d2997so5976725e9.0 for ; Thu, 07 Sep 2023 06:00:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694091637; x=1694696437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UW0LYVBQ86z9c2cV3F6pmV9ZwvsvlDsGKOMCu7v7vrc=; b=X4++IaGkFQECTjSmEpLKhng7uJobyTUamc6gtPLLsXnXZLTvkxl5CbjBhtz6TEXsYE EV7ukTUVplLdL63Y+9618kjsEMvuZAqqZZKwFpzV9uAMZNtShOvITJHHcX9oSc5dP5aX 5KssWWfPbhDHdlIDrD0W6WxEQZEEQTCar0ne+qPbLmTn1n1s982+i0xd19gJ3iEUZ+z0 hGIM57iydPGbnIsMR0OK3b7TsNIbtgqGBxfdzw0Cm7yLbjRllJxgGDxjkx1vNhAxUB4x 5EJeSN/WN02xwKnQKh+YjLVQmeImNes4KfT9ya9uA34wO6Jf5vzY2t9Shz5oN4CSu8Vo bUFg== X-Gm-Message-State: AOJu0YyCHrMyjZfbdEQN/pKvNH0xDJetn3k3Zva3uimpMxfoq+Z/q/GW Ph1YEeCXNGflw9O8bUpCfxH//6jIp9uzVa4jx6cHWsKtmdgeLrPoFRHWxsYtcqm+614Z2ylOllO Okh/ykxrIqv6pDGEnLoKu5IRhv/0Ye5jKAptiLfMwxa+Mp00/Y0q0aj8RaROuOcoMUwyDJSaTS8 w= X-Received: by 2002:a1c:721a:0:b0:401:519:c5 with SMTP id n26-20020a1c721a000000b00401051900c5mr4652251wmc.41.1694091637595; Thu, 07 Sep 2023 06:00:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGadIFPf+o/BgY2ZYe5zmx9484TGqJKwELEYrbVEHTqvdOnu0bk/fcIpAlcvWJp/FLlNQ5RqQ== X-Received: by 2002:a1c:721a:0:b0:401:519:c5 with SMTP id n26-20020a1c721a000000b00401051900c5mr4652216wmc.41.1694091637029; Thu, 07 Sep 2023 06:00:37 -0700 (PDT) Received: from [192.168.1.174] ([151.48.237.81]) by smtp.gmail.com with ESMTPSA id l10-20020a5d4bca000000b003180155493esm23243650wrt.67.2023.09.07.06.00.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 06:00:36 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 14/51] contrib/plugins: remove -soname argument Date: Thu, 7 Sep 2023 14:59:23 +0200 Message-ID: <20230907130004.500601-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230907130004.500601-1-pbonzini@redhat.com> References: <20230907130004.500601-1-pbonzini@redhat.com> MIME-Version: 1.0 Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org -soname is not needed for runtime-loaded modules. For example, Meson says: if not isinstance(target, build.SharedModule) or target.force_soname: # Add -Wl,-soname arguments on Linux, -install_name on OS X commands += linker.get_soname_args( self.environment, target.prefix, target.name, target.suffix, target.soversion, target.darwin_versions) (force_soname is set is shared modules are linked into a build target, which is not the case here. Signed-off-by: Paolo Bonzini --- contrib/plugins/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile index b2b9db9f51a..db1bd04dfa6 100644 --- a/contrib/plugins/Makefile +++ b/contrib/plugins/Makefile @@ -37,7 +37,7 @@ all: $(SONAMES) $(CC) $(CFLAGS) -c -o $@ $< lib%.so: %.o - $(CC) -shared -Wl,-soname,$@ -o $@ $^ $(LDLIBS) + $(CC) -shared -o $@ $^ $(LDLIBS) clean: rm -f *.o *.so *.d