From patchwork Thu Aug 31 22:55:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1828529 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=rP6iY1Va; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RcGm24bxBz1yfm for ; Fri, 1 Sep 2023 08:58:10 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbqap-00040A-8O; Thu, 31 Aug 2023 18:56:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbqae-0003xH-6z for qemu-devel@nongnu.org; Thu, 31 Aug 2023 18:56:40 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbqaa-0002ry-E9 for qemu-devel@nongnu.org; Thu, 31 Aug 2023 18:56:39 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b9338e4695so23353201fa.2 for ; Thu, 31 Aug 2023 15:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693522594; x=1694127394; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ShDkJ51FeoYcA6aYanaU3KOqVTFkyRgkJb5MAXD0rZI=; b=rP6iY1Va9Un1QM7mD9DWUVBYvra3Nizhyv0/DmBu2wSx5SYlss4UaRAdKoFO8J6mo5 XnyvnRAAZw4oRludrX/uAfN6ZSjFbV5F+ZFEf9z38wPG2yrBCtClu+99HLha4F47RfAc YYJGiTYpSmZqfsjAZwp0CGQeb/zgrK1nHR7h/qy84+F3VwblO8e1YU/WMO8DUmjVIuMc 7M7vadZqw3FkMCpWkqmCohb1UxyepBIlq4Xhs6//SdBKZyg2MMmf2HIBGmKkpP8rTOTK oiBTuQUTbyeMb5ow0pQup6gChTzpEcLfgSXdZF3EOEy9Ukj3X6Ayl3aJZv5LR6xipqKx Ue8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693522594; x=1694127394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ShDkJ51FeoYcA6aYanaU3KOqVTFkyRgkJb5MAXD0rZI=; b=KwcX6tSKbsLGp7SY8ndj7NOuYdaZFD8Pn/KnxrcKUrkLUXAurG3HTWm56r+eXvyawU WIRTYOAZVzRgWuPdFucakmKG8MXZlu/4COwej4WZ3a2ee1222i3DPlTeBbjKtQ96VSl1 AUmJI3fcm+w/zZQ28AUfa6+28zzBWdPks7PXy5CQoFHrlC9inbVzlDNMxq7smvIgWcXX Nr169UT42P6CcSCJM4gTnEm5KsxVdQrxfapXnYHC/IckrK0sHJR3+0W0UDU7qU6EqiHu ObX5wsgQSlGNsdB6vcXMlWnelpGU3e40DZrDxhAXB60L/DHnwIexJuFSTqX0qGXvDzfn baIg== X-Gm-Message-State: AOJu0Yw5Rtu11vg01xmjoAnRNmgh5FHA1D6KW3K1Q6482HfVXkb1tz14 1No9xy8UH5BMsWhib7sCiHJVfhd/kcyhQBKQ4SY= X-Google-Smtp-Source: AGHT+IFZsmzFYlh4WsdnWy314rryXH5h2+SY3p0jEeaENnPexmjzCBswnHjqayMjwhm17bv1CsefcQ== X-Received: by 2002:a2e:a176:0:b0:2b6:a804:4cc with SMTP id u22-20020a2ea176000000b002b6a80404ccmr414028ljl.53.1693522594650; Thu, 31 Aug 2023 15:56:34 -0700 (PDT) Received: from m1x-phil.lan ([176.187.199.245]) by smtp.gmail.com with ESMTPSA id v7-20020a1709063bc700b0099bc80d5575sm1223528ejf.200.2023.08.31.15.56.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 31 Aug 2023 15:56:34 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Markus Armbruster Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, David Gibson , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Laurent Vivier Subject: [PATCH 04/11] target/m68k: Clean up local variable shadowing Date: Fri, 1 Sep 2023 00:55:59 +0200 Message-ID: <20230831225607.30829-5-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230831225607.30829-1-philmd@linaro.org> References: <20230831225607.30829-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=philmd@linaro.org; helo=mail-lj1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Fix: target/m68k/translate.c:828:18: error: declaration shadows a local variable [-Werror,-Wshadow] TCGv tmp = tcg_temp_new(); ^ target/m68k/translate.c:801:15: note: previous declaration is here TCGv reg, tmp, result; ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 15b3701b8f..f69ae0e3b0 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -825,7 +825,7 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0, reg = get_areg(s, reg0); result = gen_ldst(s, opsize, reg, val, what, index); if (what == EA_STORE || !addrp) { - TCGv tmp = tcg_temp_new(); + tmp = tcg_temp_new(); if (reg0 == 7 && opsize == OS_BYTE && m68k_feature(s->env, M68K_FEATURE_M68K)) { tcg_gen_addi_i32(tmp, reg, 2);