From patchwork Tue Aug 15 20:15:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 1821552 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=cuPKye4f; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RQMxg5rTmz1yf2 for ; Wed, 16 Aug 2023 06:17:11 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qW0Sh-0001VT-6y; Tue, 15 Aug 2023 16:16:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qW0Sf-0001Uz-4T for qemu-devel@nongnu.org; Tue, 15 Aug 2023 16:16:17 -0400 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qW0Sb-0004vY-6l for qemu-devel@nongnu.org; Tue, 15 Aug 2023 16:16:16 -0400 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-56c85b723cfso3737435eaf.3 for ; Tue, 15 Aug 2023 13:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1692130571; x=1692735371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P9lSDeBryekDaWv/Vc78YEkpFPDXZkfJPoxtpTCKUds=; b=cuPKye4ftSE2bQsWLVzJyFLZG6ZPR9gb1PdO0OuPQyjpL3hw6pPAIAvigzeT9usq8c HDFCKGQkl/TSwsinizMo/099CgXhO+JDSmVhsk9lFJwCtsjcaNYj0sS72dKPFywGg6cC VuSxLmVmrwAVymAPev7P4iOVA/ksoYf5ONmg8zjXbF6CiBsC+qsyubTRAS1i2MN1anfs /jZnFJI8FuEx5jYn0dESaNjqGkEbLvVXpZ8erEsMSfyjgNjkMUkPmIWnUcy72yRJstH7 YlNmvzqKHRiu7EIOp0FuoEw/PYBJITf6Rdaha5XR456bmVUdjksJ/7ZEPi5xh3q7Wq5A 3bNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692130571; x=1692735371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P9lSDeBryekDaWv/Vc78YEkpFPDXZkfJPoxtpTCKUds=; b=O4OPIcv8Xz59j3q98C//O8OvV9l9P1Jw1I4xVx5q6QU0fSczFV8HqoskbBeWvZLfpN 3SiRPu2bXiHrircBCMBvp15I6ypgPzoQx6e4phXLowk7ZwAayjXHuIcqbWaj20L9KYo8 hphgfp4qt0SJ+aWQbZHUxIoVXLzMOFAj8B5nNfUpzD5eBqAYXWQ9bdno6tI7COieiByA bBByxtqbHoihXKXdYvKhETeLcmr0W4X54kzHm1GkTl7xoNRUi1HVDOemRnWiEakjcttD ieRwI3IABUqS0v2YGGYjkRF3SwXcxU2sYGgiCRKnWKRrKwTY3+lCoNIDNH4SgdSn0khM Cugw== X-Gm-Message-State: AOJu0Yw4T8qYbnSAPANf1ZlmlqXRaqNxAe/J7megh99rziD0THEoMppU EA3aAUzr+NvctIRJLYt8AZCc5rFccXxccyRShF0= X-Google-Smtp-Source: AGHT+IF/CB18TZq1uMu8r5/ScwM+24/BOl5fxrcZ3vcIzorDYOfK8tBFQT5tWJBtByU4cFPLuuBNYA== X-Received: by 2002:a05:6870:7023:b0:1bb:933b:e6da with SMTP id u35-20020a056870702300b001bb933be6damr15229318oae.27.1692130571608; Tue, 15 Aug 2023 13:16:11 -0700 (PDT) Received: from grind.. (189-69-160-189.dial-up.telesp.net.br. [189.69.160.189]) by smtp.gmail.com with ESMTPSA id o14-20020a056870e80e00b001bb5b2a958csm6658203oan.23.2023.08.15.13.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 13:16:11 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, Daniel Henrique Barboza Subject: [PATCH v7 02/12] target/riscv/cpu.c: skip 'bool' check when filtering KVM props Date: Tue, 15 Aug 2023 17:15:49 -0300 Message-ID: <20230815201559.398643-3-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815201559.398643-1-dbarboza@ventanamicro.com> References: <20230815201559.398643-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::c36; envelope-from=dbarboza@ventanamicro.com; helo=mail-oo1-xc36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org After the introduction of riscv_cpu_options[] all properties in riscv_cpu_extensions[] are booleans. This check is now obsolete. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 9a3afc0482..f10d40733a 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1907,17 +1907,11 @@ static void riscv_cpu_add_user_properties(Object *obj) * Set the default to disabled for every extension * unknown to KVM and error out if the user attempts * to enable any of them. - * - * We're giving a pass for non-bool properties since they're - * not related to the availability of extensions and can be - * safely ignored as is. */ - if (prop->info == &qdev_prop_bool) { - object_property_add(obj, prop->name, "bool", - NULL, cpu_set_cfg_unavailable, - NULL, (void *)prop->name); - continue; - } + object_property_add(obj, prop->name, "bool", + NULL, cpu_set_cfg_unavailable, + NULL, (void *)prop->name); + continue; } #endif qdev_property_add_static(dev, prop);