From patchwork Fri Aug 11 07:06:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 1820167 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ispras.ru header.i=@ispras.ru header.a=rsa-sha256 header.s=default header.b=JalHaRoj; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RMZf41kDkz1yfs for ; Fri, 11 Aug 2023 17:08:59 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUMFV-00047r-37; Fri, 11 Aug 2023 03:07:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUMFP-00047D-Ox for qemu-devel@nongnu.org; Fri, 11 Aug 2023 03:07:47 -0400 Received: from mail.ispras.ru ([83.149.199.84]) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUMFL-0008IA-23 for qemu-devel@nongnu.org; Fri, 11 Aug 2023 03:07:47 -0400 Received: from pasha-ThinkPad-X280.lan02.inno (unknown [188.162.65.26]) by mail.ispras.ru (Postfix) with ESMTPSA id ABCE640737DA; Fri, 11 Aug 2023 07:07:37 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru ABCE640737DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1691737659; bh=gbr4lRMthPPnNcEtmOCIUh/yxWtv9rNnzHNZTLTjvds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JalHaRojq1rA4qOnN6K7rZNLAGKDn9f0H1DgAd8ILrG9oTUfMFTh37GiyWNSM9RJM nHe+FAGNYDq8wJKvSzwh9md/NNu1jU8Ch6a0cIeGXfp6XHjd353Df2vFjaurUTKvAR hd3s/l/37wkH6r1acce3UIYzkkZl+lcS/bzJ3mlc= From: pavel.dovgalyuk@ispras.ru To: qemu-devel@nongnu.org Cc: philmd@linaro.org, crosa@redhat.com, wainersm@redhat.com, bleal@redhat.com, alex.bennee@linaro.org, mst@redhat.com, rafael.pizarrosolar@epfl.ch, Pavel Dovgalyuk , Pavel Dovgalyuk Subject: [PATCH 2/3] virtio-net: added replay blocker for guest_announce Date: Fri, 11 Aug 2023 10:06:07 +0300 Message-Id: <20230811070608.3383343-3-pavel.dovgalyuk@ispras.ru> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230811070608.3383343-1-pavel.dovgalyuk@ispras.ru> References: <20230811070608.3383343-1-pavel.dovgalyuk@ispras.ru> MIME-Version: 1.0 Received-SPF: pass client-ip=83.149.199.84; envelope-from=pavel.dovgalyuk@ispras.ru; helo=mail.ispras.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Pavel Dovgalyuk This patch blocks record/replay when guest_announce is enabled, because this flag breaks loading the snapshots in deterministic execution mode. Signed-off-by: Pavel Dovgalyuk --- hw/net/virtio-net.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 43fd34b0c8..2b6c246efb 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3580,6 +3580,10 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp) n->host_features |= (1ULL << VIRTIO_NET_F_MTU); } + if (n->host_features & (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE)) { + replay_add_blocker("-device virtio-net-device,guest_announce=true"); + } + if (n->net_conf.duplex_str) { if (strncmp(n->net_conf.duplex_str, "half", 5) == 0) { n->net_conf.duplex = DUPLEX_HALF;