From patchwork Tue Jul 25 09:00:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dinglimin X-Patchwork-Id: 1812289 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R99yJ3Rxbz1yYC for ; Tue, 25 Jul 2023 19:01:58 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qODum-0005pF-Ku; Tue, 25 Jul 2023 05:01:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qODuj-0005nP-KH for qemu-devel@nongnu.org; Tue, 25 Jul 2023 05:01:05 -0400 Received: from cmccmta4.chinamobile.com ([111.22.67.137] helo=cmccmta1.chinamobile.com) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qODuf-00087b-Cz for qemu-devel@nongnu.org; Tue, 25 Jul 2023 05:01:05 -0400 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[10.188.0.87]) by rmmx-syy-dmz-app04-12004 (RichMail) with SMTP id 2ee464bf8f44dfb-18ef0; Tue, 25 Jul 2023 17:00:52 +0800 (CST) X-RM-TRANSID: 2ee464bf8f44dfb-18ef0 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.108.79.99]) by rmsmtp-syy-appsvr01-12001 (RichMail) with SMTP id 2ee164bf8f41476-0a493; Tue, 25 Jul 2023 17:00:52 +0800 (CST) X-RM-TRANSID: 2ee164bf8f41476-0a493 From: dinglimin To: mjt@tls.msk.ru, richard.henderson@linaro.org Cc: qemu-devel@nongnu.org, dinglimin Subject: [PATCH] semihosting/uaccess.c: Replaced a malloc call with g_malloc. Date: Tue, 25 Jul 2023 17:00:39 +0800 Message-Id: <20230725090039.1271-1-dinglimin@cmss.chinamobile.com> X-Mailer: git-send-email 2.30.0.windows.2 In-Reply-To: <20230725080630.1083-1-dinglimin@cmss.chinamobile.com> References: <20230725080630.1083-1-dinglimin@cmss.chinamobile.com> MIME-Version: 1.0 Received-SPF: pass client-ip=111.22.67.137; envelope-from=dinglimin@cmss.chinamobile.com; helo=cmccmta1.chinamobile.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Replaced a call to malloc() and its respective call to free() with g_malloc() and g_free(). Signed-off-by: dinglimin V1 -> V2:if cpu_memory_rw_debug failed, still need to set p=NULL --- semihosting/uaccess.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/semihosting/uaccess.c b/semihosting/uaccess.c index 8018828069..2ac754cdb6 100644 --- a/semihosting/uaccess.c +++ b/semihosting/uaccess.c @@ -14,10 +14,10 @@ void *softmmu_lock_user(CPUArchState *env, target_ulong addr, target_ulong len, bool copy) { - void *p = malloc(len); + void *p = g_malloc(len); if (p && copy) { if (cpu_memory_rw_debug(env_cpu(env), addr, p, len, 0)) { - free(p); + g_free(p); p = NULL; } }