| Message ID | 20230710074639.996030-4-kkostiuk@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | QGA VSS Logging | expand |
On 10/07/2023 09.46, Konstantin Kostiuk wrote: > Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > qga/vss-win32/requester.cpp | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp > index e85b9bc633..f3eafacfc1 100644 > --- a/qga/vss-win32/requester.cpp > +++ b/qga/vss-win32/requester.cpp > @@ -26,9 +26,11 @@ > > #define DEFAULT_VSS_BACKUP_TYPE VSS_BT_FULL > > -#define err_set(e, err, fmt, ...) \ > - ((e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__, \ > - err, fmt, ## __VA_ARGS__)) > +#define err_set(e, err, fmt, ...) { \ > + (e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__, \ > + err, fmt, ## __VA_ARGS__); \ > + qga_debug(fmt, ## __VA_ARGS__); \ > +} > /* Bad idea, works only when (e)->errp != NULL: */ > #define err_is_set(e) ((e)->errp && *(e)->errp) > /* To lift this restriction, error_propagate(), like we do in QEMU code */ Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index e85b9bc633..f3eafacfc1 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -26,9 +26,11 @@ #define DEFAULT_VSS_BACKUP_TYPE VSS_BT_FULL -#define err_set(e, err, fmt, ...) \ - ((e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__, \ - err, fmt, ## __VA_ARGS__)) +#define err_set(e, err, fmt, ...) { \ + (e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__, \ + err, fmt, ## __VA_ARGS__); \ + qga_debug(fmt, ## __VA_ARGS__); \ +} /* Bad idea, works only when (e)->errp != NULL: */ #define err_is_set(e) ((e)->errp && *(e)->errp) /* To lift this restriction, error_propagate(), like we do in QEMU code */