From patchwork Fri Jun 30 18:03:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1802092 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=eOfxqV+Z; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qt3Gg4zk9z20XS for ; Sat, 1 Jul 2023 04:08:43 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFIU5-0008M7-36; Fri, 30 Jun 2023 14:04:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFITv-0008Hg-LI for qemu-devel@nongnu.org; Fri, 30 Jun 2023 14:04:31 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFITr-0006yJ-PG for qemu-devel@nongnu.org; Fri, 30 Jun 2023 14:04:31 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fbc0981755so20866275e9.1 for ; Fri, 30 Jun 2023 11:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688148266; x=1690740266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d/TY0KkPssJi6NIaD4x7Wem9brAqFmX1qoF7RdIDR9w=; b=eOfxqV+Zr0Z6pF13yplbNqFx1RF/BlJhSEb/uHWNvi0B9ZV+FhBmuhVaJp7Ox1F3No PW54VszFhlLGN4b6Q/4wxwD1cbwBNzxof7d9UXmVp3aVdI0jXLMndgA1ER224SjBWWy1 QBd9UpYRiXjPlWITdSmQtk+CjqvsLzijRKl+nWQzWLVVelZ/wbAnUqbJZgrSwaplI/Er 27vZx3A8rghsr4wgwP0JxY+qlDAwkG+l5FSnSRq/qY+NFlUkIJdOoGSpQwqZ/A8VoUtP BE83wxsPF7oeOjtPraFwrAUhTWZ4ZoSrawb0BFLHTAKtc4cyqz8PxBS/4+UHzT56zVE5 R59A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688148266; x=1690740266; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/TY0KkPssJi6NIaD4x7Wem9brAqFmX1qoF7RdIDR9w=; b=W0AhO0qwuoVBA9kKWYYvZyFyqt/7eVHGkj1Sx3Q2ygk9lYLMhBVg5suwdVhxoJhRJ5 oMXeHrws2dUIHGN2SxUrYV5IbUlotv4qSH2a6HfMVpFStr4dKT/Vf2KwEgeLJZwSDlzB 2JkyW4uVIRAV7hqciUrQBFg9qWDTVGgUd0j1v2Xxe0gb3urIWZ3Sx4xowVsrf4L89aJx Pqzyt52rzjzcTs1u0b3UqaJ15L3Mx+LNi5HRX96BrKA0Xk1v6KUkvP7AhE7maSxHtDrx xlKromyORX8s7Cj2NIlZR3yLgkfk/OMsg+gbUNyYWGsZzfsT+ed6ucxDC1J1b1Z+Xla3 STnQ== X-Gm-Message-State: AC+VfDyXM22cDPdFn422YxDXxXg3qGseT4AJ4doy7PJJh2dxaoSFf1u5 c+ZXEfnvaVydutMmNWLJKpfXsQ== X-Google-Smtp-Source: ACHHUZ6QyYtXLrnEYuPQX4B4opftt42rHtS5c2l8UDcoBb6zcIM4vroNn/0PcJ4o5kj3aFFFGY7Dqg== X-Received: by 2002:a05:600c:290:b0:3fb:c225:a75e with SMTP id 16-20020a05600c029000b003fbc225a75emr2618980wmk.24.1688148266376; Fri, 30 Jun 2023 11:04:26 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id y17-20020a1c4b11000000b003f90a604885sm19691989wma.34.2023.06.30.11.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jun 2023 11:04:25 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5AC8F1FFBF; Fri, 30 Jun 2023 19:04:24 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Paolo Bonzini , Stefan Hajnoczi , Leonardo Bras , Laurent Vivier , Peter Xu , Juan Quintela , Beraldo Leal , Radoslaw Biernacki , Qiuhao Li , Peter Maydell , Yanan Wang , Riku Voipio , Wainer dos Santos Moschetta , Mahmoud Mandour , Alexandre Iooss , =?utf-8?q?Alex_Benn=C3=A9e?= , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= , Eduardo Habkost , Thomas Huth , Laurent Vivier , Bin Meng , Marcel Apfelbaum , Bandan Das , Cleber Rosa , Richard Henderson , Leif Lindholm , Marcin Juszkiewicz , qemu-arm@nongnu.org, Darren Kenny , Alexander Bulekov , Ani Sinha Subject: [PATCH v4 04/38] docs/devel: remind developers to run CI container pipeline when updating images Date: Fri, 30 Jun 2023 19:03:49 +0100 Message-Id: <20230630180423.558337-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230630180423.558337-1-alex.bennee@linaro.org> References: <20230630180423.558337-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Ani Sinha When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there are no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrangé Message-Id: <20230506072012.10350-1-anisinha@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/testing.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index e85e26c4ca..fb651eae11 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project: `CI `__ documentation page on how to trigger gitlab CI pipelines on your change. + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI `__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``.