From patchwork Mon Jun 26 20:25:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 1800186 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=rlEhtYgZ; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QqfX94ttXz1yhT for ; Tue, 27 Jun 2023 06:27:05 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDsmH-0005uY-5a; Mon, 26 Jun 2023 16:25:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDsm5-0005dC-Ml for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:26 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDsm2-00055Q-GH for qemu-devel@nongnu.org; Mon, 26 Jun 2023 16:25:25 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-313f3a6db22so1316646f8f.3 for ; Mon, 26 Jun 2023 13:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=rlEhtYgZC/4LHm7w+Tx/oFBYOax+Ydar4y/83sQWoE7RAwC27lNK6f2/6Ivk8JHaOi NcgFkfqMY063tNjgm/xXa/Hi/zkMe5doCvIup/NeR0VgZKvXSjqlVweX9lVhPIuRXtEN fwlAbibbqsEsylWCB0a30oa1svi9ftwR81qm96uzN3m/l9KyKUT6Bv1RxI3PTOnBYL+u O3Iw5i3ApPy7SZEc1+n2hu0Ta1iD40h9oiDD1YhZV3CkmOEx5iEVL3hVcZiUJAiNerQr 3GVgWuemE3f6NBW86mxJmvx4vWQajYXYxyKOoAiiJxQnw2FAQmZpSOAKl06t31zmQoIe 7jZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687811118; x=1690403118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=ZHKAFHEUYsc9lyDayCIX9E8r3fDeuSj1OCkSFpYF2tvrbzHh9xoYMhcidrzFKPvuZl Co37SYRLjVFssr0gnH20h3zFRnceg4gtZ1ZFielSeVMSAfIsaEaMol5dKjnTm8NJZcQQ ailZrFDIyrIJXYnk97C0qDJsoHrIA0yBBcypmMqSBGEiFvBFKYB2vzknyosVrBZcTtLw kVkHjAHpyVcJE+CUTQQ1LbpQg1OCEI4Sg+cFSd17SRJVnbc8j4PnH6f7kxYPIrda0SJe p5IvJlLH8DR1nPU/m3S/EDmmQMcxbVRwvnwynLUlHpIYKv4J9D1m4Mn6bxdkVEOh9pgd 4TQw== X-Gm-Message-State: AC+VfDxZgVBxZpNuWlzy8M+MMlIvtZBu/iHMV/xZyknYPKYSqtUiNp7m Wjgpv9gUPg/IYDPA4yDg1JCo3w== X-Google-Smtp-Source: ACHHUZ4PpJai4S5/hyfdf42c0Hcs5wcQ+OynL0/pARGzdiZxmzmXkgJJbKpW4Bl2dhQj0RxIx2zA6A== X-Received: by 2002:adf:f711:0:b0:313:e553:b858 with SMTP id r17-20020adff711000000b00313e553b858mr5694878wrp.33.1687811118166; Mon, 26 Jun 2023 13:25:18 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id o10-20020a5d58ca000000b0031128382ed0sm8283322wrf.83.2023.06.26.13.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 13:25:17 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8A25F1FFBF; Mon, 26 Jun 2023 21:25:16 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Qiuhao Li , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Juan Quintela , Marcin Juszkiewicz , =?utf-8?q?Daniel_P=2E_B?= =?utf-8?q?errang=C3=A9?= , Eduardo Habkost , Alexandre Iooss , Peter Xu , Yanan Wang , Mahmoud Mandour , Peter Maydell , Bin Meng , Marcel Apfelbaum , Beraldo Leal , Richard Henderson , Leif Lindholm , Paolo Bonzini , Thomas Huth , Riku Voipio , Cleber Rosa , Alexander Bulekov , =?utf-8?q?Alex_Benn=C3=A9e?= , Radoslaw Biernacki , Bandan Das , Leonardo Bras , qemu-arm@nongnu.org, Darren Kenny , Wainer dos Santos Moschetta , Laurent Vivier , Ani Sinha Subject: [PATCH v2 4/6] docs/devel: remind developers to run CI container pipeline when updating images Date: Mon, 26 Jun 2023 21:25:13 +0100 Message-Id: <20230626202516.2507915-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230626202516.2507915-1-alex.bennee@linaro.org> References: <20230626202516.2507915-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Ani Sinha When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there are no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrangé Message-Id: <20230506072012.10350-1-anisinha@redhat.com> Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 203facb417..8f18052ba7 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project: `CI `__ documentation page on how to trigger gitlab CI pipelines on your change. + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI `__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``.