diff mbox series

[v2,4/8] target/tricore: Indirect jump insns use tcg_gen_lookup_and_goto_ptr()

Message ID 20230616152808.1499082-5-kbastian@mail.uni-paderborn.de
State New
Headers show
Series TriCore Privilege Levels | expand

Commit Message

Bastian Koppelmann June 16, 2023, 3:28 p.m. UTC 
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 target/tricore/translate.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Richard Henderson June 18, 2023, 5:34 p.m. UTC | #1 
On 6/16/23 17:28, Bastian Koppelmann wrote:
> @@ -6075,7 +6076,7 @@ static void decode_rr_idirect(DisasContext *ctx)
>       default:
>           generate_trap(ctx, TRAPC_INSN_ERR, TIN2_IOPC);
>       }
> -    ctx->base.is_jmp = DISAS_EXIT;
> +    ctx->base.is_jmp = DISAS_JUMP;
>   }

Not quite correct, as generate_trap is NORETURN.
Return early from the function there?


r~
diff mbox series

Patch

diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 6164ba6539..5515dfa3f3 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -39,6 +39,7 @@ 
 
 #define DISAS_EXIT        DISAS_TARGET_0
 #define DISAS_EXIT_UPDATE DISAS_TARGET_1
+#define DISAS_JUMP        DISAS_TARGET_2
 
 /*
  * TCG registers
@@ -6075,7 +6076,7 @@  static void decode_rr_idirect(DisasContext *ctx)
     default:
         generate_trap(ctx, TRAPC_INSN_ERR, TIN2_IOPC);
     }
-    ctx->base.is_jmp = DISAS_EXIT;
+    ctx->base.is_jmp = DISAS_JUMP;
 }
 
 static void decode_rr_divide(DisasContext *ctx)
@@ -8389,6 +8390,9 @@  static void tricore_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)
     case DISAS_EXIT:
         tcg_gen_exit_tb(NULL, 0);
         break;
+    case DISAS_JUMP:
+        tcg_gen_lookup_and_goto_ptr();
+        break;
     case DISAS_NORETURN:
         break;
     default: