| Message ID | 20230601163123.1805282-6-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: enable meson test timeouts to improve debuggability | expand |
On 01/06/2023 18.31, Daniel P. Berrangé wrote: > This is reliably hitting the current 2 minute timeout in GitLab CI > for the TCI job, and even hits a 4 minute timeout. That sentence is somewhat hard to parse... maybe rather: This is reliably hitting the current 2 minute timeout in GitLab CI, and for the TCI job, it even hits a 4 minute timeout. ? > At 6 minutes it > looks sufficiently reliable. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index d9fa30edbc..4f45369421 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -1,6 +1,6 @@ > slow_qtests = { > 'aspeed_smc-test': 120, > - 'bios-tables-test' : 120, > + 'bios-tables-test' : 360, > 'migration-test' : 300, > 'npcm7xx_pwm-test': 150, > 'qom-test' : 420, With the commit description updated: Reviewed-by: Thomas Huth <thuth@redhat.com>
On 01/06/2023 18.31, Daniel P. Berrangé wrote: > This is reliably hitting the current 2 minute timeout in GitLab CI > for the TCI job, and even hits a 4 minute timeout. At 6 minutes it > looks sufficiently reliable. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/qtest/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index d9fa30edbc..4f45369421 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -1,6 +1,6 @@ > slow_qtests = { > 'aspeed_smc-test': 120, > - 'bios-tables-test' : 120, > + 'bios-tables-test' : 360, > 'migration-test' : 300, > 'npcm7xx_pwm-test': 150, > 'qom-test' : 420, Seems not to be enough for the CI (in the TCI job which is very slow in running the tests): https://gitlab.com/thuth/qemu/-/jobs/4412460439 An earlier run needed 403 seconds here already: https://gitlab.com/thuth/qemu/-/jobs/4411373383 Thomas
On Mon, Jun 05, 2023 at 01:37:39PM +0200, Thomas Huth wrote: > On 01/06/2023 18.31, Daniel P. Berrangé wrote: > > This is reliably hitting the current 2 minute timeout in GitLab CI > > for the TCI job, and even hits a 4 minute timeout. At 6 minutes it > > looks sufficiently reliable. > > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > --- > > tests/qtest/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > > index d9fa30edbc..4f45369421 100644 > > --- a/tests/qtest/meson.build > > +++ b/tests/qtest/meson.build > > @@ -1,6 +1,6 @@ > > slow_qtests = { > > 'aspeed_smc-test': 120, > > - 'bios-tables-test' : 120, > > + 'bios-tables-test' : 360, > > 'migration-test' : 300, > > 'npcm7xx_pwm-test': 150, > > 'qom-test' : 420, > > Seems not to be enough for the CI (in the TCI job which is very slow in > running the tests): > > https://gitlab.com/thuth/qemu/-/jobs/4412460439 > > An earlier run needed 403 seconds here already: > > https://gitlab.com/thuth/qemu/-/jobs/4411373383 Guess gitlab CI was less heavily loaded when i ran my many tests at the end of last week. 9 minutes it is. With regards, Daniel
diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index d9fa30edbc..4f45369421 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -1,6 +1,6 @@ slow_qtests = { 'aspeed_smc-test': 120, - 'bios-tables-test' : 120, + 'bios-tables-test' : 360, 'migration-test' : 300, 'npcm7xx_pwm-test': 150, 'qom-test' : 420,
This is reliably hitting the current 2 minute timeout in GitLab CI for the TCI job, and even hits a 4 minute timeout. At 6 minutes it looks sufficiently reliable. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)