diff mbox series

[2/6] qtest: bump migration-test timeout to 5 minutes

Message ID 20230601163123.1805282-3-berrange@redhat.com
State New
Headers show
Series tests: enable meson test timeouts to improve debuggability | expand

Commit Message

Daniel P. Berrangé June 1, 2023, 4:31 p.m. UTC
The migration test should take between 1 min 30 and 2 mins on reasonably
modern hardware. The test is not especially compute bound, rather its
running time is dominated by the guest RAM size relative to the
bandwidth cap, which forces each iteration to take at least 30 seconds.
None the less under high load conditions with multiple QEMU processes
spawned and competing with other parallel tests, the worst case running
time might be somewhat extended. Bumping the timeout to 5 minutes gives
us good headroom, while still catching stuck tests relatively quickly.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/qtest/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth June 1, 2023, 6:39 p.m. UTC | #1
On 01/06/2023 18.31, Daniel P. Berrangé wrote:
> The migration test should take between 1 min 30 and 2 mins on reasonably
> modern hardware. The test is not especially compute bound, rather its
> running time is dominated by the guest RAM size relative to the
> bandwidth cap, which forces each iteration to take at least 30 seconds.
> None the less under high load conditions with multiple QEMU processes
> spawned and competing with other parallel tests, the worst case running
> time might be somewhat extended. Bumping the timeout to 5 minutes gives
> us good headroom, while still catching stuck tests relatively quickly.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qtest/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index 18d046b53c..6684591fcf 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -1,6 +1,6 @@
>   slow_qtests = {
>     'bios-tables-test' : 120,
> -  'migration-test' : 150,
> +  'migration-test' : 300,
>     'npcm7xx_pwm-test': 150,
>     'qom-test' : 300,
>     'test-hmp' : 120,

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index 18d046b53c..6684591fcf 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -1,6 +1,6 @@ 
 slow_qtests = {
   'bios-tables-test' : 120,
-  'migration-test' : 150,
+  'migration-test' : 300,
   'npcm7xx_pwm-test': 150,
   'qom-test' : 300,
   'test-hmp' : 120,