| Message ID | 20230530134313.387252-1-npiggin@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] target/ppc: PMU do not clear MMCR0[FCECE] on performance monitor alert | expand |
On 5/30/23 10:43, Nicholas Piggin wrote: > FCECE does not get cleared according to the ISA v3.1B. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> And queued. Daniel > target/ppc/power8-pmu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c > index c4c331c6b5..af065115f2 100644 > --- a/target/ppc/power8-pmu.c > +++ b/target/ppc/power8-pmu.c > @@ -289,7 +289,6 @@ static void fire_PMC_interrupt(PowerPCCPU *cpu) > pmu_update_cycles(env); > > if (env->spr[SPR_POWER_MMCR0] & MMCR0_FCECE) { > - env->spr[SPR_POWER_MMCR0] &= ~MMCR0_FCECE; > env->spr[SPR_POWER_MMCR0] |= MMCR0_FC; > > /* Changing MMCR0_FC requires summaries and hflags update */
diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c index c4c331c6b5..af065115f2 100644 --- a/target/ppc/power8-pmu.c +++ b/target/ppc/power8-pmu.c @@ -289,7 +289,6 @@ static void fire_PMC_interrupt(PowerPCCPU *cpu) pmu_update_cycles(env); if (env->spr[SPR_POWER_MMCR0] & MMCR0_FCECE) { - env->spr[SPR_POWER_MMCR0] &= ~MMCR0_FCECE; env->spr[SPR_POWER_MMCR0] |= MMCR0_FC; /* Changing MMCR0_FC requires summaries and hflags update */
FCECE does not get cleared according to the ISA v3.1B. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- target/ppc/power8-pmu.c | 1 - 1 file changed, 1 deletion(-)