diff mbox series

[1/3] target/arm: Explain why we need to select ARM_V7M

Message ID 20230523180525.29994-2-farosas@suse.de
State New
Headers show
Series arm/Kconfig: Some convenience changes | expand

Commit Message

Fabiano Rosas May 23, 2023, 6:05 p.m. UTC 
We currently need to select ARM_V7M unconditionally when TCG is
present in the build because some translate.c helpers and the whole of
m_helpers.c are not yet under CONFIG_ARM_V7M.

Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 target/arm/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Philippe Mathieu-Daudé May 24, 2023, 6:25 a.m. UTC | #1 
On 23/5/23 20:05, Fabiano Rosas wrote:
> We currently need to select ARM_V7M unconditionally when TCG is
> present in the build because some translate.c helpers and the whole of
> m_helpers.c are not yet under CONFIG_ARM_V7M.
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   target/arm/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/target/arm/Kconfig b/target/arm/Kconfig
index 5947366f6e..bf57d739cd 100644
--- a/target/arm/Kconfig
+++ b/target/arm/Kconfig
@@ -1,6 +1,9 @@ 
 config ARM
     bool
     select ARM_COMPATIBLE_SEMIHOSTING if TCG
+
+    # We need to select this until we move m_helper.c and the
+    # translate.c v7m helpers under ARM_V7M.
     select ARM_V7M if TCG
 
 config AARCH64