From patchwork Sun Mar 26 05:20:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bui Quang Minh X-Patchwork-Id: 1761218 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=UaptGFFo; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Pkkrn3gD4z1yYB for ; Sun, 26 Mar 2023 16:24:09 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgIqd-0007kS-L0; Sun, 26 Mar 2023 01:23:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgIqb-0007jI-O4 for qemu-devel@nongnu.org; Sun, 26 Mar 2023 01:23:17 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgIqa-00089Z-8b for qemu-devel@nongnu.org; Sun, 26 Mar 2023 01:23:17 -0400 Received: by mail-pj1-x1029.google.com with SMTP id l7so4965315pjg.5 for ; Sat, 25 Mar 2023 22:23:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679808195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hc8u8RCEWRkcWK3lR3VFupEwaZp5j6qGGE9YvB3aeP0=; b=UaptGFFot3fXH0eWVu051t1Jd9fpbOlHoAN6rJyyJwhoRia9GGfMiW68E/olTBY3cx J6Rbx0KUFSHaDK+2JCZjbc96RArIYQDogIFMBRHl9vQXhXY5/HKGfgyvb3989Mw16HKR 4LKbxNv3EXzk5rWtMMGdwGnJ49V7FVnXAAiwzGOrYDX07YUYXPphEuxmID7tHYkq4j1j xTFY6CmNAZ4obTP7vgMWZyO8RNVCueap4sSHTTxyTFiC/r9T/d5gzoK40VPORuNCiXZI B0mTRf2dTe6iJKFq7fJL0yJnqUy7/zxIXLZdZNgrZCzXHczbGoJ4ABJmgB1tD3WrPsF5 oeUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679808195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hc8u8RCEWRkcWK3lR3VFupEwaZp5j6qGGE9YvB3aeP0=; b=qMpP3vnZWTbyzWzkT1RysCzwLfq6znEggcOBDtzOuN7EaEkFhXzZH7OOyaz8KiZGeM X/9vkg/G3UKwLLCtvW4OlNO9vS/T81lPC7JMW3gNVQrn0VQwrfdDLay165VQTvhaMzHB UxLZpYnyctz99gXiTu8qlvo6PO2B16FJD56uNJMHCtXvu+G3oZNgVN6j0X0xVNu+V73S 2ThT5Mfyxs4dsRD4Jk2feRDJ2dSiPD99NZ+T83V0VRAzx0utYLd2zdaxWgIeQHNGIm0s CokEO0064wL0R/bkCmDotDF9lIr/nsx/lKbymT05YHsYRRA9iO1nMU/P+ce9CoAYFUhZ T+oA== X-Gm-Message-State: AAQBX9dEVg8AO3o+jncva0LjUrINCa7SxriR1+p4cDBaKh3riNcJ1qkc QjMGtEcxF/bO8hx8WDKLbX75nKBzZ3g6MA== X-Google-Smtp-Source: AKy350YVZp+WsqJXhKSxpmlPqcDh90KDVZxBId3xesrix9uc2PrNylP3y4p3Z/h15ZHDbcU38xyISA== X-Received: by 2002:a17:902:ea11:b0:1a1:f06b:f171 with SMTP id s17-20020a170902ea1100b001a1f06bf171mr8221273plg.17.1679808195167; Sat, 25 Mar 2023 22:23:15 -0700 (PDT) Received: from localhost.localdomain ([113.173.97.170]) by smtp.googlemail.com with ESMTPSA id bc9-20020a170902930900b001a20b31a23fsm5020258plb.293.2023.03.25.22.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 22:23:14 -0700 (PDT) From: Bui Quang Minh To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S . Tsirkin" , Marcel Apfelbaum , David Woodhouse , Igor Mammedov , =?utf-8?q?Alex_Benn=C3=A9e?= , Bui Quang Minh Subject: [PATCH v2 4/5] intel_iommu: allow Extended Interrupt Mode when using userspace APIC Date: Sun, 26 Mar 2023 12:20:38 +0700 Message-Id: <20230326052039.33717-5-minhquangbui99@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230326052039.33717-1-minhquangbui99@gmail.com> References: <20230326052039.33717-1-minhquangbui99@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=minhquangbui99@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org As userspace APIC now supports x2APIC, intel interrupt remapping hardware can be set to EIM mode when userspace local APIC is used. Signed-off-by: Bui Quang Minh --- hw/i386/intel_iommu.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index faade7def8..a34a4c8196 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -4045,17 +4045,6 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp) && x86_iommu_ir_supported(x86_iommu) ? ON_OFF_AUTO_ON : ON_OFF_AUTO_OFF; } - if (s->intr_eim == ON_OFF_AUTO_ON && !s->buggy_eim) { - if (!kvm_irqchip_is_split()) { - error_setg(errp, "eim=on requires accel=kvm,kernel-irqchip=split"); - return false; - } - if (!kvm_enable_x2apic()) { - error_setg(errp, "eim=on requires support on the KVM side" - "(X2APIC_API, first shipped in v4.7)"); - return false; - } - } /* Currently only address widths supported are 39 and 48 bits */ if ((s->aw_bits != VTD_HOST_AW_39BIT) &&