| Message ID | 20230316003411.129462-1-iii@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu | expand |
On 16/3/23 01:34, Ilya Leoshkevich wrote: > When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. > Fix by using qemu_fprintf() instead of qemu_printf() in the respective > places. > > Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints") > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> > --- > > Resend of https://patchew.org/QEMU/20220725142854.177451-1-iii@linux.ibm.com/ > with a trivial rebase. > > target/sh4/translate.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Le 16/03/2023 à 08:52, Philippe Mathieu-Daudé a écrit : > On 16/3/23 01:34, Ilya Leoshkevich wrote: >> When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. >> Fix by using qemu_fprintf() instead of qemu_printf() in the respective >> places. >> >> Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints") >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> >> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp> >> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> >> --- >> >> Resend of https://patchew.org/QEMU/20220725142854.177451-1-iii@linux.ibm.com/ >> with a trivial rebase. >> >> target/sh4/translate.c | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/target/sh4/translate.c b/target/sh4/translate.c index 97da8bce488..6e40d5dd6a1 100644 --- a/target/sh4/translate.c +++ b/target/sh4/translate.c @@ -171,16 +171,16 @@ void superh_cpu_dump_state(CPUState *cs, FILE *f, int flags) qemu_fprintf(f, "sgr=0x%08x dbr=0x%08x delayed_pc=0x%08x fpul=0x%08x\n", env->sgr, env->dbr, env->delayed_pc, env->fpul); for (i = 0; i < 24; i += 4) { - qemu_printf("r%d=0x%08x r%d=0x%08x r%d=0x%08x r%d=0x%08x\n", - i, env->gregs[i], i + 1, env->gregs[i + 1], - i + 2, env->gregs[i + 2], i + 3, env->gregs[i + 3]); + qemu_fprintf(f, "r%d=0x%08x r%d=0x%08x r%d=0x%08x r%d=0x%08x\n", + i, env->gregs[i], i + 1, env->gregs[i + 1], + i + 2, env->gregs[i + 2], i + 3, env->gregs[i + 3]); } if (env->flags & TB_FLAG_DELAY_SLOT) { - qemu_printf("in delay slot (delayed_pc=0x%08x)\n", - env->delayed_pc); + qemu_fprintf(f, "in delay slot (delayed_pc=0x%08x)\n", + env->delayed_pc); } else if (env->flags & TB_FLAG_DELAY_SLOT_COND) { - qemu_printf("in conditional delay slot (delayed_pc=0x%08x)\n", - env->delayed_pc); + qemu_fprintf(f, "in conditional delay slot (delayed_pc=0x%08x)\n", + env->delayed_pc); } else if (env->flags & TB_FLAG_DELAY_SLOT_RTE) { qemu_fprintf(f, "in rte delay slot (delayed_pc=0x%08x)\n", env->delayed_pc);
When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. Fix by using qemu_fprintf() instead of qemu_printf() in the respective places. Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints") Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> --- Resend of https://patchew.org/QEMU/20220725142854.177451-1-iii@linux.ibm.com/ with a trivial rebase. target/sh4/translate.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)