| Message ID | 20230310103106.62124-5-faithilikerun@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add zone append write for zoned device | expand |
On Fri, 2023-03-10 at 18:31 +0800, Sam Li wrote: > Signed-off-by: Sam Li <faithilikerun@gmail.com> Looks good, Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com> > block/file-posix.c | 3 +++ > block/trace-events | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/block/file-posix.c b/block/file-posix.c > index 2ba9174778..5187f810e5 100644 > --- a/block/file-posix.c > +++ b/block/file-posix.c > @@ -2489,6 +2489,8 @@ out: > if (!BDRV_ZT_IS_CONV(wps->wp[index])) { > if (type & QEMU_AIO_ZONE_APPEND) { > *s->offset = wps->wp[index]; > + trace_zbd_zone_append_complete(bs, *s->offset > + >> BDRV_SECTOR_BITS); > } > /* Advance the wp if needed */ > if (offset + bytes > wps->wp[index]) { > @@ -3537,6 +3539,7 @@ static int coroutine_fn > raw_co_zone_append(BlockDriverState *bs, > len += iov_len; > } > > + trace_zbd_zone_append(bs, *offset >> BDRV_SECTOR_BITS); > return raw_co_prw(bs, *offset, len, qiov, QEMU_AIO_ZONE_APPEND); > } > #endif > diff --git a/block/trace-events b/block/trace-events > index 3f4e1d088a..32665158d6 100644 > --- a/block/trace-events > +++ b/block/trace-events > @@ -211,6 +211,8 @@ file_hdev_is_sg(int type, int version) "SG device found: > type=%d, version=%d" > file_flush_fdatasync_failed(int err) "errno %d" > zbd_zone_report(void *bs, unsigned int nr_zones, int64_t sector) "bs %p report > %d zones starting at sector offset 0x%" PRIx64 "" > zbd_zone_mgmt(void *bs, const char *op_name, int64_t sector, int64_t len) "bs > %p %s starts at sector offset 0x%" PRIx64 " over a range of 0x%" PRIx64 " > sectors" > +zbd_zone_append(void *bs, int64_t sector) "bs %p append at sector offset 0x%" > PRIx64 "" > +zbd_zone_append_complete(void *bs, int64_t sector) "bs %p returns append > sector 0x%" PRIx64 "" > > # ssh.c > sftp_error(const char *op, const char *ssh_err, int ssh_err_code, int > sftp_err_code) "%s failed: %s (libssh error code: %d, sftp error code: %d)"
diff --git a/block/file-posix.c b/block/file-posix.c index 2ba9174778..5187f810e5 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2489,6 +2489,8 @@ out: if (!BDRV_ZT_IS_CONV(wps->wp[index])) { if (type & QEMU_AIO_ZONE_APPEND) { *s->offset = wps->wp[index]; + trace_zbd_zone_append_complete(bs, *s->offset + >> BDRV_SECTOR_BITS); } /* Advance the wp if needed */ if (offset + bytes > wps->wp[index]) { @@ -3537,6 +3539,7 @@ static int coroutine_fn raw_co_zone_append(BlockDriverState *bs, len += iov_len; } + trace_zbd_zone_append(bs, *offset >> BDRV_SECTOR_BITS); return raw_co_prw(bs, *offset, len, qiov, QEMU_AIO_ZONE_APPEND); } #endif diff --git a/block/trace-events b/block/trace-events index 3f4e1d088a..32665158d6 100644 --- a/block/trace-events +++ b/block/trace-events @@ -211,6 +211,8 @@ file_hdev_is_sg(int type, int version) "SG device found: type=%d, version=%d" file_flush_fdatasync_failed(int err) "errno %d" zbd_zone_report(void *bs, unsigned int nr_zones, int64_t sector) "bs %p report %d zones starting at sector offset 0x%" PRIx64 "" zbd_zone_mgmt(void *bs, const char *op_name, int64_t sector, int64_t len) "bs %p %s starts at sector offset 0x%" PRIx64 " over a range of 0x%" PRIx64 " sectors" +zbd_zone_append(void *bs, int64_t sector) "bs %p append at sector offset 0x%" PRIx64 "" +zbd_zone_append_complete(void *bs, int64_t sector) "bs %p returns append sector 0x%" PRIx64 "" # ssh.c sftp_error(const char *op, const char *ssh_err, int ssh_err_code, int sftp_err_code) "%s failed: %s (libssh error code: %d, sftp error code: %d)"
Signed-off-by: Sam Li <faithilikerun@gmail.com> --- block/file-posix.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+)