| Message ID | 20230206140809.26028-8-farosas@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | Kconfig vs. default devices | expand |
On Mon, 6 Feb 2023 at 14:10, Fabiano Rosas <farosas@suse.de> wrote: > > This machine hardcodes initialization of the USB device, so select the > corresponding Kconfig. It is not enough to have it as "default y if > XLNX_VERSAL" at usb/Kconfig because building --without-default-devices > disables the default selection resulting in: > > $ ./qemu-system-aarch64 -M xlnx-zcu102 > qemu-system-aarch64: missing object type 'usb_dwc3' > Aborted (core dumped) > > Signed-off-by: Fabiano Rosas <farosas@suse.de> > --- > hw/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 296d4f5176..552e3d04ee 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -405,6 +405,7 @@ config XLNX_VERSAL > select OR_IRQ > select XLNX_BBRAM > select XLNX_EFUSE_VERSAL > + select XLNX_USB_SUBSYS > > config NPCM7XX > bool Shouldn't we also remove the now-useless "default y if XNLX_VERSAL" line from the XLNX_USB_SUBSYS stanza ? thanks -- PMM
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 296d4f5176..552e3d04ee 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -405,6 +405,7 @@ config XLNX_VERSAL select OR_IRQ select XLNX_BBRAM select XLNX_EFUSE_VERSAL + select XLNX_USB_SUBSYS config NPCM7XX bool
This machine hardcodes initialization of the USB device, so select the corresponding Kconfig. It is not enough to have it as "default y if XLNX_VERSAL" at usb/Kconfig because building --without-default-devices disables the default selection resulting in: $ ./qemu-system-aarch64 -M xlnx-zcu102 qemu-system-aarch64: missing object type 'usb_dwc3' Aborted (core dumped) Signed-off-by: Fabiano Rosas <farosas@suse.de> --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)