| Message ID | 20221216214924.4711-2-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/smmu-common: Avoid using inlined functions with external linkage | expand |
On 12/16/22 13:49, Philippe Mathieu-Daudé wrote: > This function is not used anywhere outside this file, > so we can make the function "static void". > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Hi On 12/16/22 22:49, Philippe Mathieu-Daudé wrote: > This function is not used anywhere outside this file, > so we can make the function "static void". > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Eric Auger <eric.auger@redhat.com> Thanks Eric > --- > hw/arm/smmu-common.c | 2 +- > include/hw/arm/smmu-common.h | 3 --- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c > index 220838525d..9f196625a2 100644 > --- a/hw/arm/smmu-common.c > +++ b/hw/arm/smmu-common.c > @@ -483,7 +483,7 @@ static void smmu_unmap_notifier_range(IOMMUNotifier *n) > } > > /* Unmap all notifiers attached to @mr */ > -inline void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr) > +static void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr) > { > IOMMUNotifier *n; > > diff --git a/include/hw/arm/smmu-common.h b/include/hw/arm/smmu-common.h > index 21e62342e9..c5683af07d 100644 > --- a/include/hw/arm/smmu-common.h > +++ b/include/hw/arm/smmu-common.h > @@ -173,7 +173,4 @@ void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova, > /* Unmap the range of all the notifiers registered to any IOMMU mr */ > void smmu_inv_notifiers_all(SMMUState *s); > > -/* Unmap the range of all the notifiers registered to @mr */ > -void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr); > - > #endif /* HW_ARM_SMMU_COMMON_H */
diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c index 220838525d..9f196625a2 100644 --- a/hw/arm/smmu-common.c +++ b/hw/arm/smmu-common.c @@ -483,7 +483,7 @@ static void smmu_unmap_notifier_range(IOMMUNotifier *n) } /* Unmap all notifiers attached to @mr */ -inline void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr) +static void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr) { IOMMUNotifier *n; diff --git a/include/hw/arm/smmu-common.h b/include/hw/arm/smmu-common.h index 21e62342e9..c5683af07d 100644 --- a/include/hw/arm/smmu-common.h +++ b/include/hw/arm/smmu-common.h @@ -173,7 +173,4 @@ void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova, /* Unmap the range of all the notifiers registered to any IOMMU mr */ void smmu_inv_notifiers_all(SMMUState *s); -/* Unmap the range of all the notifiers registered to @mr */ -void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr); - #endif /* HW_ARM_SMMU_COMMON_H */
This function is not used anywhere outside this file, so we can make the function "static void". Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/arm/smmu-common.c | 2 +- include/hw/arm/smmu-common.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-)