| Message ID | 20221103083425.100590-1-akihiko.odaki@daynix.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests/qtest/libqos/e1000e: Use E1000_STATUS_ASDV_1000 | expand |
On 3/11/22 09:34, Akihiko Odaki wrote: > Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have > the same value, and E1000_STATUS_ASDV_1000 should be used here because > E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here > while E1000_STATUS_LAN_INIT_DONE is a value used for a different purpose > with a variant of e1000e family different from the one implemented in > QEMU. > > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> > --- > tests/qtest/libqos/e1000e.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c index 11d9f55c66..178d61d04f 100644 --- a/tests/qtest/libqos/e1000e.c +++ b/tests/qtest/libqos/e1000e.c @@ -130,8 +130,8 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj) /* Check the device status - link and speed */ val = e1000e_macreg_read(&d->e1000e, E1000_STATUS); - g_assert_cmphex(val & (E1000_STATUS_LU | E1000_STATUS_LAN_INIT_DONE), - ==, E1000_STATUS_LU | E1000_STATUS_LAN_INIT_DONE); + g_assert_cmphex(val & (E1000_STATUS_LU | E1000_STATUS_ASDV_1000), + ==, E1000_STATUS_LU | E1000_STATUS_ASDV_1000); /* Initialize TX/RX logic */ e1000e_macreg_write(&d->e1000e, E1000_RCTL, 0);
Nemonics E1000_STATUS_LAN_INIT_DONE and E1000_STATUS_ASDV_1000 have the same value, and E1000_STATUS_ASDV_1000 should be used here because E1000_STATUS_ASDV_1000 represents the auto-detected speed tested here while E1000_STATUS_LAN_INIT_DONE is a value used for a different purpose with a variant of e1000e family different from the one implemented in QEMU. Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- tests/qtest/libqos/e1000e.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)