From patchwork Sun Oct 16 14:51:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Li X-Patchwork-Id: 1690438 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=BaWID3U3; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Mr38R1x6xz23jp for ; Mon, 17 Oct 2022 01:55:35 +1100 (AEDT) Received: from localhost ([::1]:59710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ok537-0004IU-58 for incoming@patchwork.ozlabs.org; Sun, 16 Oct 2022 10:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59614) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ok4zg-0006hc-El; Sun, 16 Oct 2022 10:52:01 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:35782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ok4zd-0004o0-Aa; Sun, 16 Oct 2022 10:51:59 -0400 Received: by mail-pf1-x42b.google.com with SMTP id y191so9024270pfb.2; Sun, 16 Oct 2022 07:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pHsgBhzlwBVeB6QEnnmSuesWcU89mHN1XvRx5wVrRFM=; b=BaWID3U3MRd3IrQvJQhZ6dXcKgidVD1/SGKBfGj75UVJSffNnZ+AwoFZMFOs4GEmVg 5twN0YrG9ZVH7kyTmWsuPbtFQwYrChcjnW5cCYqOgFHUj/UhuUW6XYc5cx/d5tmRQeQS XZZY4Zg2zq3q6Okc/J2ssRJLQp6oj9xKuWMKzaay4nCLudsl/KTR3JpQ425X9BGuQw02 xlFV82IiQGKjDYABl7pHDBOw2235OIHxQ5gHE9yDcluXaZEQnTzbvngpOSr8z+ilephr Icpl63hV4JPINIvxNXbmwJ9/Qm7kpjeFynfDxlZSXy4J44GiDIZcWuAL6FUW2Nr/aH0h EB7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pHsgBhzlwBVeB6QEnnmSuesWcU89mHN1XvRx5wVrRFM=; b=3NWfyZJID1Y5nrCN9MZoc9DQjD2gvE+I4NLlG+uYWFqZZ17M1QyztHlsJeaAYx1eKQ oerxT9yYoaMPCXB7TlzQeEc8k9fr8I98fTzamIhOW2tz6j/MYhAf3iTB2s8VurqjqLKV fkpt6yWqnBa/GJtwcTumTVP4APhZ5UrBckEqmdGq/kDeRNQ0ctz8gH/1HA2TZkmP/poz XwbBBfg/es4T/rKi0wYo+7ZORTOoUL+rl1MmtmhOGjPcaL+jGVHT095gjVRdU0sai78L opmk++DkxCovROksD0L5l1j61n0+FCI0XY8jtYfn6EB5CudV9GXAfXj8CGO8sypb75C9 WkjA== X-Gm-Message-State: ACrzQf2hN7YpLe9ikeZYJxRZAz72Zm/suQY1XO6qstC4lYjo5+NbfHGZ o1WvEOdJ4YpjUWKudHtQ+9KvmPc+phadgg== X-Google-Smtp-Source: AMsMyM4s6MHpqFrCQ3Y9SRAUxFnR3x4Gg9WUN4gKpomuszgvXU8DWNtZdCu7IT+r2Dw2JD1aTrjg5A== X-Received: by 2002:a05:6a02:201:b0:463:5d19:4213 with SMTP id bh1-20020a056a02020100b004635d194213mr6823451pgb.377.1665931915889; Sun, 16 Oct 2022 07:51:55 -0700 (PDT) Received: from roots.. ([183.221.93.248]) by smtp.gmail.com with ESMTPSA id z27-20020aa79e5b000000b005377c74c409sm5143619pfq.4.2022.10.16.07.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Oct 2022 07:51:55 -0700 (PDT) From: Sam Li To: qemu-devel@nongnu.org Cc: Markus Armbruster , Kevin Wolf , Fam Zheng , damien.lemoal@opensource.wdc.com, Stefan Hajnoczi , Hanna Reitz , qemu-block@nongnu.org, hare@suse.de, Eric Blake , dmitry.fomichev@wdc.com, Sam Li Subject: [PATCH v12 5/7] config: add check to block layer Date: Sun, 16 Oct 2022 22:51:08 +0800 Message-Id: <20221016145110.171262-6-faithilikerun@gmail.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221016145110.171262-1-faithilikerun@gmail.com> References: <20221016145110.171262-1-faithilikerun@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=faithilikerun@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Putting zoned/non-zoned BlockDrivers on top of each other is not allowed. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Hannes Reinecke Reviewed-by: Dmitry Fomichev --- block.c | 19 +++++++++++++++++++ block/file-posix.c | 12 ++++++++++++ block/raw-format.c | 1 + include/block/block_int-common.h | 5 +++++ 4 files changed, 37 insertions(+) diff --git a/block.c b/block.c index 1fbf6b9e69..5d6fa4a25a 100644 --- a/block.c +++ b/block.c @@ -7951,6 +7951,25 @@ void bdrv_add_child(BlockDriverState *parent_bs, BlockDriverState *child_bs, return; } + /* + * Non-zoned block drivers do not follow zoned storage constraints + * (i.e. sequential writes to zones). Refuse mixing zoned and non-zoned + * drivers in a graph. + */ + if (!parent_bs->drv->supports_zoned_children && + child_bs->bl.zoned == BLK_Z_HM) { + /* + * The host-aware model allows zoned storage constraints and random + * write. Allow mixing host-aware and non-zoned drivers. Using + * host-aware device as a regular device. + */ + error_setg(errp, "Cannot add a %s child to a %s parent", + child_bs->bl.zoned == BLK_Z_HM ? "zoned" : "non-zoned", + parent_bs->drv->supports_zoned_children ? + "support zoned children" : "not support zoned children"); + return; + } + if (!QLIST_EMPTY(&child_bs->parents)) { error_setg(errp, "The node %s already has a parent", child_bs->node_name); diff --git a/block/file-posix.c b/block/file-posix.c index bd28e3eaea..7c5a330fc1 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -776,6 +776,18 @@ static int raw_open_common(BlockDriverState *bs, QDict *options, goto fail; } } +#ifdef CONFIG_BLKZONED + /* + * The kernel page cache does not reliably work for writes to SWR zones + * of zoned block device because it can not guarantee the order of writes. + */ + if ((strcmp(bs->drv->format_name, "zoned_host_device") == 0) && + (!(s->open_flags & O_DIRECT))) { + error_setg(errp, "driver=zoned_host_device was specified, but it " + "requires cache.direct=on, which was not specified."); + return -EINVAL; /* No host kernel page cache */ + } +#endif if (S_ISBLK(st.st_mode)) { #ifdef __linux__ diff --git a/block/raw-format.c b/block/raw-format.c index bac43f1d25..18dc52a150 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -615,6 +615,7 @@ static void raw_child_perm(BlockDriverState *bs, BdrvChild *c, BlockDriver bdrv_raw = { .format_name = "raw", .instance_size = sizeof(BDRVRawState), + .supports_zoned_children = true, .bdrv_probe = &raw_probe, .bdrv_reopen_prepare = &raw_reopen_prepare, .bdrv_reopen_commit = &raw_reopen_commit, diff --git a/include/block/block_int-common.h b/include/block/block_int-common.h index cdc06e77a6..37dddc603c 100644 --- a/include/block/block_int-common.h +++ b/include/block/block_int-common.h @@ -127,6 +127,11 @@ struct BlockDriver { */ bool is_format; + /* + * Set to true if the BlockDriver supports zoned children. + */ + bool supports_zoned_children; + /* * Drivers not implementing bdrv_parse_filename nor bdrv_open should have * this field set to true, except ones that are defined only by their