| Message ID | 20220830161545.84198-15-victortoso@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qapi examples fixes and rfc for another generator | expand |
Victor Toso <victortoso@redhat.com> writes: > The example's return type has several missing mandatory member names. > Fix it. > > Problem was noticed when using the example as a test case for Go > bindings. > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/migration.json | 56 +++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 52 insertions(+), 4 deletions(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index 81185d4311..2ac26d1971 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -295,7 +295,18 @@ > # "duplicate":123, > # "normal":123, > # "normal-bytes":123456, > -# "dirty-sync-count":15 > +# "dirty-sync-count":15, > +# "mbps":0, > +# "skipped":0, > +# "postcopy-requests":0, > +# "page-size":0, > +# "multifd-bytes":0, > +# "pages-per-second":0, > +# "precopy-bytes":0, > +# "downtime-bytes":0, > +# "postcopy-bytes":0, > +# "dirty-sync-missed-zero-copy":0, > +# "dirty-pages-rate":0 > # } > # } > # } > @@ -321,7 +332,18 @@ > # "duplicate":123, > # "normal":123, > # "normal-bytes":123456, > -# "dirty-sync-count":15 > +# "dirty-sync-count":15, > +# "mbps":0, > +# "skipped":0, > +# "postcopy-requests":0, > +# "page-size":0, > +# "multifd-bytes":0, > +# "pages-per-second":0, > +# "precopy-bytes":0, > +# "downtime-bytes":0, > +# "postcopy-bytes":0, > +# "dirty-sync-missed-zero-copy":0, > +# "dirty-pages-rate":0 > # } > # } > # } > @@ -342,12 +364,38 @@ > # "duplicate":123, > # "normal":123, > # "normal-bytes":123456, > -# "dirty-sync-count":15 > +# "dirty-sync-count":15, > +# "mbps":1, > +# "skipped":1, > +# "postcopy-requests":1, > +# "page-size":1, > +# "multifd-bytes":1, > +# "pages-per-second":1, > +# "precopy-bytes":1, > +# "downtime-bytes":1, > +# "postcopy-bytes":1, > +# "dirty-sync-missed-zero-copy":1, > +# "dirty-pages-rate":1 > # }, > # "disk":{ > # "total":20971520, > # "remaining":20880384, > -# "transferred":91136 > +# "transferred":91136, > +# "duplicate":2, > +# "skipped":2, > +# "normal":2, > +# "normal-bytes":2, > +# "dirty-pages-rate":2, > +# "mbps":2, > +# "dirty-sync-count":2, > +# "postcopy-requests":2, > +# "page-size":2, > +# "multifd-bytes":2, > +# "pages-per-second":2, > +# "precopy-bytes":2, > +# "downtime-bytes":2, > +# "postcopy-bytes":2, > +# "dirty-sync-missed-zero-copy":2 > # } > # } > # } Full example output is fairly long. Perhaps that's what we want. Or perhaps we'd prefer abridged output. See also my review of PATCH 03.
diff --git a/qapi/migration.json b/qapi/migration.json index 81185d4311..2ac26d1971 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -295,7 +295,18 @@ # "duplicate":123, # "normal":123, # "normal-bytes":123456, -# "dirty-sync-count":15 +# "dirty-sync-count":15, +# "mbps":0, +# "skipped":0, +# "postcopy-requests":0, +# "page-size":0, +# "multifd-bytes":0, +# "pages-per-second":0, +# "precopy-bytes":0, +# "downtime-bytes":0, +# "postcopy-bytes":0, +# "dirty-sync-missed-zero-copy":0, +# "dirty-pages-rate":0 # } # } # } @@ -321,7 +332,18 @@ # "duplicate":123, # "normal":123, # "normal-bytes":123456, -# "dirty-sync-count":15 +# "dirty-sync-count":15, +# "mbps":0, +# "skipped":0, +# "postcopy-requests":0, +# "page-size":0, +# "multifd-bytes":0, +# "pages-per-second":0, +# "precopy-bytes":0, +# "downtime-bytes":0, +# "postcopy-bytes":0, +# "dirty-sync-missed-zero-copy":0, +# "dirty-pages-rate":0 # } # } # } @@ -342,12 +364,38 @@ # "duplicate":123, # "normal":123, # "normal-bytes":123456, -# "dirty-sync-count":15 +# "dirty-sync-count":15, +# "mbps":1, +# "skipped":1, +# "postcopy-requests":1, +# "page-size":1, +# "multifd-bytes":1, +# "pages-per-second":1, +# "precopy-bytes":1, +# "downtime-bytes":1, +# "postcopy-bytes":1, +# "dirty-sync-missed-zero-copy":1, +# "dirty-pages-rate":1 # }, # "disk":{ # "total":20971520, # "remaining":20880384, -# "transferred":91136 +# "transferred":91136, +# "duplicate":2, +# "skipped":2, +# "normal":2, +# "normal-bytes":2, +# "dirty-pages-rate":2, +# "mbps":2, +# "dirty-sync-count":2, +# "postcopy-requests":2, +# "page-size":2, +# "multifd-bytes":2, +# "pages-per-second":2, +# "precopy-bytes":2, +# "downtime-bytes":2, +# "postcopy-bytes":2, +# "dirty-sync-missed-zero-copy":2 # } # } # }
The example's return type has several missing mandatory member names. Fix it. Problem was noticed when using the example as a test case for Go bindings. Signed-off-by: Victor Toso <victortoso@redhat.com> --- qapi/migration.json | 56 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 52 insertions(+), 4 deletions(-)