| Message ID | 20220726092248.128336-6-frankja@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | dump: Add arch section and s390x PV dump | expand |
Hi On Tue, Jul 26, 2022 at 1:23 PM Janosch Frank <frankja@linux.ibm.com> wrote: > > We can safely remove next_block and start as both of them aren't used > anymore due to the block iteration re-work. > I suggest removing next_block with the patch that gets rids of its usage. > Also we add comments to the remaining guest memory related struct > members and a comment on top to group them. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> With that change, Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > include/sysemu/dump.h | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h > index 6ce3c24197..24ebb02660 100644 > --- a/include/sysemu/dump.h > +++ b/include/sysemu/dump.h > @@ -166,11 +166,10 @@ typedef struct DumpState { > hwaddr memory_offset; > int fd; > > - GuestPhysBlock *next_block; > - ram_addr_t start; > - bool has_filter; > - int64_t begin; > - int64_t length; > + /* Guest memory related data */ > + bool has_filter; /* Are we dumping parts of the memory? */ > + int64_t begin; /* Start address of the chunk we want to dump */ > + int64_t length; /* Length of the dump we want to dump */ > > uint8_t *note_buf; /* buffer for notes */ > size_t note_buf_offset; /* the writing place in note_buf */ > -- > 2.34.1 >
On 7/26/22 11:22, Janosch Frank wrote: > We can safely remove next_block and start as both of them aren't used > anymore due to the block iteration re-work. > > Also we add comments to the remaining guest memory related struct > members and a comment on top to group them. > > Signed-off-by: Janosch Frank <frankja@linux.ibm.com> Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com> > --- > include/sysemu/dump.h | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h > index 6ce3c24197..24ebb02660 100644 > --- a/include/sysemu/dump.h > +++ b/include/sysemu/dump.h > @@ -166,11 +166,10 @@ typedef struct DumpState { > hwaddr memory_offset; > int fd; > > - GuestPhysBlock *next_block; > - ram_addr_t start; > - bool has_filter; > - int64_t begin; > - int64_t length; > + /* Guest memory related data */ > + bool has_filter; /* Are we dumping parts of the memory? */ Maybe /* Are we dumping part of the memory only? */ > + int64_t begin; /* Start address of the chunk we want to dump */ > + int64_t length; /* Length of the dump we want to dump */ > > uint8_t *note_buf; /* buffer for notes */ > size_t note_buf_offset; /* the writing place in note_buf */
diff --git a/include/sysemu/dump.h b/include/sysemu/dump.h index 6ce3c24197..24ebb02660 100644 --- a/include/sysemu/dump.h +++ b/include/sysemu/dump.h @@ -166,11 +166,10 @@ typedef struct DumpState { hwaddr memory_offset; int fd; - GuestPhysBlock *next_block; - ram_addr_t start; - bool has_filter; - int64_t begin; - int64_t length; + /* Guest memory related data */ + bool has_filter; /* Are we dumping parts of the memory? */ + int64_t begin; /* Start address of the chunk we want to dump */ + int64_t length; /* Length of the dump we want to dump */ uint8_t *note_buf; /* buffer for notes */ size_t note_buf_offset; /* the writing place in note_buf */
We can safely remove next_block and start as both of them aren't used anymore due to the block iteration re-work. Also we add comments to the remaining guest memory related struct members and a comment on top to group them. Signed-off-by: Janosch Frank <frankja@linux.ibm.com> --- include/sysemu/dump.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)