| Message ID | 20220328140604.41484-4-victortoso@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix some qapi examples and a TODO section | expand |
Victor Toso <victortoso@redhat.com> writes: > Example output lacks mandatory member @reason. Provide it. > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/block-core.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 63c30a5378..46580ac551 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5058,7 +5058,8 @@ > # "data": { "device": "ide0-hd1", > # "node-name": "#block212", > # "operation": "write", > -# "action": "stop" }, > +# "action": "stop", > +# "reason": "No space left on device" }, > # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > # > ## I briefly wondered whether "reason": "No space left on device" implies "nospace: true, but it looks like it doesn't. Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qapi/block-core.json b/qapi/block-core.json index 63c30a5378..46580ac551 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5058,7 +5058,8 @@ # "data": { "device": "ide0-hd1", # "node-name": "#block212", # "operation": "write", -# "action": "stop" }, +# "action": "stop", +# "reason": "No space left on device" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ##
Example output lacks mandatory member @reason. Provide it. Signed-off-by: Victor Toso <victortoso@redhat.com> --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)