| Message ID | 20220328140604.41484-12-victortoso@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix some qapi examples and a TODO section | expand |
Victor Toso <victortoso@redhat.com> writes: > Example output lacks mandatory member @timestamp. Provide it. > > While @flags is an optional member, Uh, it isn't. > if it is defined then all its > members should be include. For that reason, we add @recursive member. Perhaps: Example output lacks mandatory member flags.recursive. Provide it. Happy to make such a change in my tree. > Minor: Change quotes from '' to "" in @action-required member. > > Signed-off-by: Victor Toso <victortoso@redhat.com> > Reviewed-by: John Snow <jsnow@redhat.com> > --- > qapi/run-state.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/run-state.json b/qapi/run-state.json > index 7f1c788c4e..8124220bd9 100644 > --- a/qapi/run-state.json > +++ b/qapi/run-state.json > @@ -571,7 +571,9 @@ > # <- { "event": "MEMORY_FAILURE", > # "data": { "recipient": "hypervisor", > # "action": "fatal", > -# "flags": { 'action-required': false } } > +# "flags": { "action-required": false, > +# "recursive": false } }, > +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } > # > ## > { 'event': 'MEMORY_FAILURE', With the commit message fixed: Reviewed-by: Markus Armbruster <armbru@redhat.com>
Hi, On Tue, Mar 29, 2022 at 05:52:47PM +0200, Markus Armbruster wrote: > Victor Toso <victortoso@redhat.com> writes: > > > Example output lacks mandatory member @timestamp. Provide it. > > > > While @flags is an optional member, > > Uh, it isn't. Wow! I was so sure I saw "*flags" before. Nice catch. > > if it is defined then all its > > members should be include. For that reason, we add @recursive member. > > Perhaps: > > Example output lacks mandatory member flags.recursive. Provide it. > > Happy to make such a change in my tree. Yes, many thanks! > > Minor: Change quotes from '' to "" in @action-required member. > > > > Signed-off-by: Victor Toso <victortoso@redhat.com> > > Reviewed-by: John Snow <jsnow@redhat.com> > > --- > > qapi/run-state.json | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/run-state.json b/qapi/run-state.json > > index 7f1c788c4e..8124220bd9 100644 > > --- a/qapi/run-state.json > > +++ b/qapi/run-state.json > > @@ -571,7 +571,9 @@ > > # <- { "event": "MEMORY_FAILURE", > > # "data": { "recipient": "hypervisor", > > # "action": "fatal", > > -# "flags": { 'action-required': false } } > > +# "flags": { "action-required": false, > > +# "recursive": false } }, > > +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } > > # > > ## > > { 'event': 'MEMORY_FAILURE', > > With the commit message fixed: > Reviewed-by: Markus Armbruster <armbru@redhat.com> Cheers, Victor
diff --git a/qapi/run-state.json b/qapi/run-state.json index 7f1c788c4e..8124220bd9 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -571,7 +571,9 @@ # <- { "event": "MEMORY_FAILURE", # "data": { "recipient": "hypervisor", # "action": "fatal", -# "flags": { 'action-required': false } } +# "flags": { "action-required": false, +# "recursive": false } }, +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } # ## { 'event': 'MEMORY_FAILURE',