| Message ID | 20210805193431.307761-5-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | qom: Fix broken OBJECT_CHECK usage | expand |
On Thu, Aug 05, 2021 at 03:34:29PM -0400, Eduardo Habkost wrote: > We have a SCLPEventsBus struct type defined, but no QOM type > checkers are declared for the type. > > Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and > have a SCLP_EVENT_BUS typecast wrapper defined. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Cc: Richard Henderson <richard.henderson@linaro.org> > Cc: David Hildenbrand <david@redhat.com> > Cc: Cornelia Huck <cohuck@redhat.com> > Cc: Halil Pasic <pasic@linux.ibm.com> > Cc: Christian Borntraeger <borntraeger@de.ibm.com> > Cc: Thomas Huth <thuth@redhat.com> > Cc: qemu-s390x@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/s390x/event-facility.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c > index 0a65e16cdd9..9f7883d6e20 100644 > --- a/hw/s390x/event-facility.c > +++ b/hw/s390x/event-facility.c > @@ -328,6 +328,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB *sccb) > /* qemu object creation and initialization functions */ > > #define TYPE_SCLP_EVENTS_BUS "s390-sclp-events-bus" > +OBJECT_DECLARE_SIMPLE_TYPE(SCLPEventsBus, SCLP_EVENT_BUS) Oops, a typo (should be SCLP_EVENTS_BUS instead). I will submit v2 later as a standalone patch.
diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index 0a65e16cdd9..9f7883d6e20 100644 --- a/hw/s390x/event-facility.c +++ b/hw/s390x/event-facility.c @@ -328,6 +328,7 @@ static void write_event_mask(SCLPEventFacility *ef, SCCB *sccb) /* qemu object creation and initialization functions */ #define TYPE_SCLP_EVENTS_BUS "s390-sclp-events-bus" +OBJECT_DECLARE_SIMPLE_TYPE(SCLPEventsBus, SCLP_EVENT_BUS) static const TypeInfo sclp_events_bus_info = { .name = TYPE_SCLP_EVENTS_BUS,
We have a SCLPEventsBus struct type defined, but no QOM type checkers are declared for the type. Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and have a SCLP_EVENT_BUS typecast wrapper defined. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Cc: Richard Henderson <richard.henderson@linaro.org> Cc: David Hildenbrand <david@redhat.com> Cc: Cornelia Huck <cohuck@redhat.com> Cc: Halil Pasic <pasic@linux.ibm.com> Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Thomas Huth <thuth@redhat.com> Cc: qemu-s390x@nongnu.org Cc: qemu-devel@nongnu.org --- hw/s390x/event-facility.c | 1 + 1 file changed, 1 insertion(+)