From patchwork Fri Jul 9 20:28:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1503387 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GM4cG628Sz9sSs for ; Sat, 10 Jul 2021 06:33:18 +1000 (AEST) Received: from localhost ([::1]:52446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xBU-0003b3-Hw for incoming@patchwork.ozlabs.org; Fri, 09 Jul 2021 16:33:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6z-0006AK-Jp; Fri, 09 Jul 2021 16:28:37 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6x-0007Uw-FO; Fri, 09 Jul 2021 16:28:37 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MJV9S-1liEMh1MWu-00JqP5; Fri, 09 Jul 2021 22:28:31 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 6/9] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Date: Fri, 9 Jul 2021 22:28:21 +0200 Message-Id: <20210709202824.578187-7-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:C6OHJj5D0XQZuQpLW3xomHX72aiL7JorBTC/WVgaq0MH8wBrb0r mPTs6ydho4Qw49cPUGzdnw6CCkFA1XaxflXBupKi7kTPwlPaZdl1RNDIK80XpoK9XZKVB/B mM6xeu/TlPYMD+XQCgcG/OjqHHOiNxC/oBzyhdcISoLDwI+DLjU6n4uHuMAgHFnjT/1dmY6 v5hBXee/fQ/ckSLEybVWA== X-UI-Out-Filterresults: notjunk:1;V03:K0:BsSTyS9ruLI=:bJF2ZR/aPVGzw2EloZbw8R vkYO7jCuSLYNu5W/1ky3ODeV/EPa9V/fBJItl6nA+Whj1guULZ683RO+4A/iDS383Juk3k5q3 5oAsWWgeiV6xFHezakbgUY7laOlKLERmi2xkTKxhFzSAz+AqP4GyVjJOuT84yKm6bVbDG/lUQ g7MAnAMMicI5WAnRnd0PgBLuvt9eLkVS96SxG4E7MjyO0+gut/2BK1FUa5Eugq2Qaskumq3Y5 LshgyptiaOaluAHKmbsyzLDXRMIQSwfN13Q7duCC5UMZnxHIHkKnVPmWEly+Mx26lpskeRRIg FFmR0mnzP5id3KKRA0HCcgqKUPn7k4UfOEHvd3b4Gi1Lu2VvZtzxRazXvvaSlpvw4otnkPujB B5yiA9Uzujszy4qojx3MZijk/a97E8839/jHVPTPOlrefSZtcHi45GiRtsct8VnjjUMs9hfPm RggYR4+xVMxralyGjevtZbhjwb9UaE4BNgMct5KoSjZfkEkbsYgstgti2uDzGnZFdDCBa8Lwu 1xb96h61vZIcAKDs9QDmWLHyNwIVawHgtkSFZNMpww+tniyad+jd5zo5Lf/53AedjLMhGS+DV 4IB/WC/nWot1TYFyJZBfN7UpV8EsLte5YR9ic0bsZ/Wu4gVVgfs2Y8xd4evWKo/99C+1ZyodL oX2mq1Wq/zRHaDah/Shsw5heH56dHqzow5484WDgA8XTCekYo0Eg2QpIAUdV2zfxgPsuFFay9 T8fA4PiI28zCyPTrdYxd0X3xB6rdvphGjlPjHYQWg3QDv+OFjFo3oJWXlAnuqYTrbbDElHKWr owM0wkftrLPJ/WrGVJvB7MlsGCY5uAjTjO3to3kUZA2M1OW7+Jlp+K5W9nyxEZqQh3bRzEJ Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_L3=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Such comments make reviewing this file somehow easier. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20210523094040.3516968-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 6dcf3baf56b7..874377f37a70 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -2447,6 +2447,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int value) } } +/* Called within rcu_read_lock(). */ static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq) { uint16_t old, new; @@ -2483,6 +2484,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bool wrap, return vring_need_event(off, new, old); } +/* Called within rcu_read_lock(). */ static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq) { VRingPackedDescEvent e;