| Message ID | 20210526091626.3388262-2-npiggin@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ppc: LPCR synchronisation fixes | expand |
On 5/26/21 11:16 AM, Nicholas Piggin wrote: > Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit > bits") moved this logic but did not remove the comment from the > previous location. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> > --- > hw/ppc/spapr_rtas.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index 03355b4c0a..63d96955c0 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -164,7 +164,6 @@ static void rtas_start_cpu(PowerPCCPU *callcpu, SpaprMachineState *spapr, > env->msr = (1ULL << MSR_SF) | (1ULL << MSR_ME); > hreg_compute_hflags(env); > > - /* Enable Power-saving mode Exit Cause exceptions for the new CPU */ > lpcr = env->spr[SPR_LPCR]; > if (!pcc->interrupts_big_endian(callcpu)) { > lpcr |= LPCR_ILE; >
On Wed, 26 May 2021 19:16:24 +1000 Nicholas Piggin <npiggin@gmail.com> wrote: > Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit > bits") moved this logic but did not remove the comment from the > previous location. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- Reviewed-by: Greg Kurz <groug@kaod.org> > hw/ppc/spapr_rtas.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index 03355b4c0a..63d96955c0 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -164,7 +164,6 @@ static void rtas_start_cpu(PowerPCCPU *callcpu, SpaprMachineState *spapr, > env->msr = (1ULL << MSR_SF) | (1ULL << MSR_ME); > hreg_compute_hflags(env); > > - /* Enable Power-saving mode Exit Cause exceptions for the new CPU */ > lpcr = env->spr[SPR_LPCR]; > if (!pcc->interrupts_big_endian(callcpu)) { > lpcr |= LPCR_ILE;
On Wed, May 26, 2021 at 07:16:24PM +1000, Nicholas Piggin wrote: > Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit > bits") moved this logic but did not remove the comment from the > previous location. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Applied to ppc-for-6.1, thanks. > --- > hw/ppc/spapr_rtas.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c > index 03355b4c0a..63d96955c0 100644 > --- a/hw/ppc/spapr_rtas.c > +++ b/hw/ppc/spapr_rtas.c > @@ -164,7 +164,6 @@ static void rtas_start_cpu(PowerPCCPU *callcpu, SpaprMachineState *spapr, > env->msr = (1ULL << MSR_SF) | (1ULL << MSR_ME); > hreg_compute_hflags(env); > > - /* Enable Power-saving mode Exit Cause exceptions for the new CPU */ > lpcr = env->spr[SPR_LPCR]; > if (!pcc->interrupts_big_endian(callcpu)) { > lpcr |= LPCR_ILE;
diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 03355b4c0a..63d96955c0 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -164,7 +164,6 @@ static void rtas_start_cpu(PowerPCCPU *callcpu, SpaprMachineState *spapr, env->msr = (1ULL << MSR_SF) | (1ULL << MSR_ME); hreg_compute_hflags(env); - /* Enable Power-saving mode Exit Cause exceptions for the new CPU */ lpcr = env->spr[SPR_LPCR]; if (!pcc->interrupts_big_endian(callcpu)) { lpcr |= LPCR_ILE;
Commit 47a9b551547 ("spapr: Clean up handling of LPCR power-saving exit bits") moved this logic but did not remove the comment from the previous location. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- hw/ppc/spapr_rtas.c | 1 - 1 file changed, 1 deletion(-)