| Message ID | 20201224031750.52146-6-jiaxun.yang@flygoat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/8] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT | expand |
On 12/24/20 4:17 AM, Jiaxun Yang wrote: > modetty is not handled by kernel and the parameter > here seems unreasonable. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > v3: Bring busclock back > --- > hw/mips/fuloong2e.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c > index d846ef7b00..c4843dd15e 100644 > --- a/hw/mips/fuloong2e.c > +++ b/hw/mips/fuloong2e.c > @@ -159,10 +159,8 @@ static uint64_t load_kernel(CPUMIPSState *env) > } > > /* Setup minimum environment variables */ > - prom_set(prom_buf, index++, "busclock=33000000"); > prom_set(prom_buf, index++, "cpuclock=100000000"); > prom_set(prom_buf, index++, "memsize=%"PRIi64, loaderparams.ram_size / MiB); > - prom_set(prom_buf, index++, "modetty0=38400n8r"); > prom_set(prom_buf, index++, NULL); This makes my Linux kernel 2.6 test behave oddly: (4/4) tests/acceptance/machine_mips_fuloong2e.py:MipsFuloong2e.test_linux_kernel_isa_serial: console: Linux version 2.6.27.7lemote (root@debian) (gcc version 4.1.3 20080623 (prerelease) (Debian 4.1.2-23)) #6 Fri Dec 12 00:11:25 CST 2008 console: busclock=0, cpuclock=-2145008360,memsize=256,highmemsize=0 console: console [early0] enabled console: CPU revision is: 00006302 (ICT Loongson-2)
On 1/1/21 7:05 PM, Philippe Mathieu-Daudé wrote: > On 12/24/20 4:17 AM, Jiaxun Yang wrote: >> modetty is not handled by kernel and the parameter >> here seems unreasonable. >> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> >> --- >> v3: Bring busclock back >> --- >> hw/mips/fuloong2e.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c >> index d846ef7b00..c4843dd15e 100644 >> --- a/hw/mips/fuloong2e.c >> +++ b/hw/mips/fuloong2e.c >> @@ -159,10 +159,8 @@ static uint64_t load_kernel(CPUMIPSState *env) >> } >> >> /* Setup minimum environment variables */ >> - prom_set(prom_buf, index++, "busclock=33000000"); Ah but you still removed busclock... This might explain why. >> prom_set(prom_buf, index++, "cpuclock=100000000"); >> prom_set(prom_buf, index++, "memsize=%"PRIi64, loaderparams.ram_size / MiB); >> - prom_set(prom_buf, index++, "modetty0=38400n8r"); >> prom_set(prom_buf, index++, NULL); > > This makes my Linux kernel 2.6 test behave oddly: > > (4/4) > tests/acceptance/machine_mips_fuloong2e.py:MipsFuloong2e.test_linux_kernel_isa_serial: > console: Linux version 2.6.27.7lemote (root@debian) (gcc version 4.1.3 > 20080623 (prerelease) (Debian 4.1.2-23)) #6 Fri Dec 12 00:11:25 CST 2008 > console: busclock=0, cpuclock=-2145008360,memsize=256,highmemsize=0 > console: console [early0] enabled > console: CPU revision is: 00006302 (ICT Loongson-2) >
diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c index d846ef7b00..c4843dd15e 100644 --- a/hw/mips/fuloong2e.c +++ b/hw/mips/fuloong2e.c @@ -159,10 +159,8 @@ static uint64_t load_kernel(CPUMIPSState *env) } /* Setup minimum environment variables */ - prom_set(prom_buf, index++, "busclock=33000000"); prom_set(prom_buf, index++, "cpuclock=100000000"); prom_set(prom_buf, index++, "memsize=%"PRIi64, loaderparams.ram_size / MiB); - prom_set(prom_buf, index++, "modetty0=38400n8r"); prom_set(prom_buf, index++, NULL); rom_add_blob_fixed("prom", prom_buf, prom_size, ENVP_PADDR);
modetty is not handled by kernel and the parameter here seems unreasonable. Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> --- v3: Bring busclock back --- hw/mips/fuloong2e.c | 2 -- 1 file changed, 2 deletions(-)