diff mbox series

[v2,2/4] configure: the docdir option should passed to meson as is.

Message ID 20201015201035.1964-3-luoyonggang@gmail.com
State New
Headers show
Series Fixes docs building on msys2/mingw | expand

Commit Message

Yonggang Luo Oct. 15, 2020, 8:10 p.m. UTC
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Paolo Bonzini Oct. 15, 2020, 9:23 p.m. UTC | #1
Why?

Paolo

Il gio 15 ott 2020, 22:11 Yonggang Luo <luoyonggang@gmail.com> ha scritto:

> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>  configure | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index f839c2a557..1ce31f97b4 100755
> --- a/configure
> +++ b/configure
> @@ -971,7 +971,7 @@ for opt do
>    ;;
>    --with-suffix=*) qemu_suffix="$optarg"
>    ;;
> -  --docdir=*) qemu_docdir="$optarg"
> +  --docdir=*) docdir="$optarg"
>    ;;
>    --sysconfdir=*) sysconfdir="$optarg"
>    ;;
> @@ -5770,7 +5770,6 @@ fi
>  qemu_confdir="$sysconfdir/$qemu_suffix"
>  qemu_moddir="$libdir/$qemu_suffix"
>  qemu_datadir="$datadir/$qemu_suffix"
> -qemu_docdir="$docdir/$qemu_suffix"
>  qemu_localedir="$datadir/locale"
>  qemu_icondir="$datadir/icons"
>  qemu_desktopdir="$datadir/applications"
> --
> 2.28.0.windows.1
>
>
Yonggang Luo Oct. 15, 2020, 9:39 p.m. UTC | #2
Grep  qemu_docdir and docdir  in configure, you will know why,  qemu_docdir
not used at all in configure,

On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Why?
>
> Paolo
>
> Il gio 15 ott 2020, 22:11 Yonggang Luo <luoyonggang@gmail.com> ha scritto:
>>
>> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
>> ---
>>  configure | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index f839c2a557..1ce31f97b4 100755
>> --- a/configure
>> +++ b/configure
>> @@ -971,7 +971,7 @@ for opt do
>>    ;;
>>    --with-suffix=*) qemu_suffix="$optarg"
>>    ;;
>> -  --docdir=*) qemu_docdir="$optarg"
>> +  --docdir=*) docdir="$optarg"
>>    ;;
>>    --sysconfdir=*) sysconfdir="$optarg"
>>    ;;
>> @@ -5770,7 +5770,6 @@ fi
>>  qemu_confdir="$sysconfdir/$qemu_suffix"
>>  qemu_moddir="$libdir/$qemu_suffix"
>>  qemu_datadir="$datadir/$qemu_suffix"
>> -qemu_docdir="$docdir/$qemu_suffix"
>>  qemu_localedir="$datadir/locale"
>>  qemu_icondir="$datadir/icons"
>>  qemu_desktopdir="$datadir/applications"
>> --
>> 2.28.0.windows.1
>>


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo
diff mbox series

Patch

diff --git a/configure b/configure
index f839c2a557..1ce31f97b4 100755
--- a/configure
+++ b/configure
@@ -971,7 +971,7 @@  for opt do
   ;;
   --with-suffix=*) qemu_suffix="$optarg"
   ;;
-  --docdir=*) qemu_docdir="$optarg"
+  --docdir=*) docdir="$optarg"
   ;;
   --sysconfdir=*) sysconfdir="$optarg"
   ;;
@@ -5770,7 +5770,6 @@  fi
 qemu_confdir="$sysconfdir/$qemu_suffix"
 qemu_moddir="$libdir/$qemu_suffix"
 qemu_datadir="$datadir/$qemu_suffix"
-qemu_docdir="$docdir/$qemu_suffix"
 qemu_localedir="$datadir/locale"
 qemu_icondir="$datadir/icons"
 qemu_desktopdir="$datadir/applications"