From patchwork Tue Sep 8 19:48:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yonggang Luo X-Patchwork-Id: 1359952 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=FNC+ch7Y; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BmG3Q6C5cz9sSJ for ; Wed, 9 Sep 2020 05:50:42 +1000 (AEST) Received: from localhost ([::1]:44968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFjdY-0008BS-Qn for incoming@patchwork.ozlabs.org; Tue, 08 Sep 2020 15:50:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFjbt-000584-8o; Tue, 08 Sep 2020 15:48:57 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:43406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFjbr-0002UP-Iq; Tue, 08 Sep 2020 15:48:56 -0400 Received: by mail-pf1-x442.google.com with SMTP id f18so22799pfa.10; Tue, 08 Sep 2020 12:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qfatTX2Pahw3MLtTsQ90jsfuDFxj9dg6nxrJN7ZCMQY=; b=FNC+ch7YMYzASNmiUcgDSkK3IOBxHrYSVLawrpj4e5S9iAUrc7LJL9QPhkMyhvoZbI S8jX2hQfZ/DIQVhyDSX3+CMSMAdok5OkUpmmpgGb00RkPKf1lD5QhHQJcDjTfcJWCVce pcVrheKdNqb36ku742Cgo5+S4pmc61C3kD9Ynh3XlHsilddfnrPhXlqADnrH3XtcPNdN 0EZglBzlEKE3g9vUNWsENQgN+2sUsybV3za85y//FZMhK8bF+kzyzwJXI0ksac4k4OrG sNOmXSW9Ei1Pv3MvGzJWxMQ3zpVXCiLX1sBYgjSRj9gNTQvK8XRq4/+Iky82EP1sbH6u tn/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qfatTX2Pahw3MLtTsQ90jsfuDFxj9dg6nxrJN7ZCMQY=; b=LvAJoYG85vLd1Z0Dr+4ghiI8JMaElxHDRZ70hSbqhGRvNFcOXWRUgjavlRIExWCg71 EGai49J0TvXPWgr4HC1DoChpATnyiEs1R7zE1BxB6o9FpZLpcBB8KqI7qgx+zoEd1K0+ dKF8Ex69EKrGa2xwaqXTS4cZcrReh5nexO7lzFCRdc/QT0JFGuok3EEkjwmXflEyku5V yMIQI8iQ3jNZKlSeHebFLpmq+gDxUXJnUlBDJeIQ+tjgmX+gIsVVNCJH9umMq17koIJq LOBnVgnsOKoRjp03aO9YNNlgB4tciwIPvbmUWrtSR+F+Fhc+dYNZ4xvKr6acNQtkMYe1 imkw== X-Gm-Message-State: AOAM533z+Crw1ddOZ4dKOw/hJ62oncYOF/jqFQFiKxXhQscjfDBfow+r 2AmibzsantZ0WEJLjUpuRq3hEGdluo/3LZaT X-Google-Smtp-Source: ABdhPJw0DWfVh8XdJz4hcghoxvqGIXvokdTs+pmWDFjhfi21V8EJFloLpdy9uz2PE+5QMsZNfaMVxQ== X-Received: by 2002:a63:355:: with SMTP id 82mr257177pgd.384.1599594533472; Tue, 08 Sep 2020 12:48:53 -0700 (PDT) Received: from localhost.localdomain ([222.95.248.6]) by smtp.googlemail.com with ESMTPSA id n127sm216922pfn.155.2020.09.08.12.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 12:48:52 -0700 (PDT) From: Yonggang Luo To: qemu-devel@nongnu.org Subject: [PATCH 04/16] curses: Fixes curses compiling errors. Date: Wed, 9 Sep 2020 03:48:08 +0800 Message-Id: <20200908194820.702-5-luoyonggang@gmail.com> X-Mailer: git-send-email 2.28.0.windows.1 In-Reply-To: <20200908194820.702-1-luoyonggang@gmail.com> References: <20200908194820.702-1-luoyonggang@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=luoyonggang@gmail.com; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Ed Maste , Michael Roth , qemu-block@nongnu.org, Stefan Weil , Xie Changlong , Richard Henderson , Markus Armbruster , Max Reitz , Yonggang Luo , Gerd Hoffmann , Wen Congyang , Li-Wen Hsu , Peter Lieven Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This is the compiling error: ../ui/curses.c: In function 'curses_refresh': ../ui/curses.c:256:5: error: 'next_maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~~~~~~~ ../ui/curses.c:302:32: note: 'next_maybe_keycode' was declared here 302 | enum maybe_keycode next_maybe_keycode; | ^~~~~~~~~~~~~~~~~~ ../ui/curses.c:256:5: error: 'maybe_keycode' may be used uninitialized in this function [-Werror=maybe-uninitialized] 256 | curses2foo(_curses2keycode, _curseskey2keycode, chr, maybe_keycode) | ^~~~~~~~~~ ../ui/curses.c:265:24: note: 'maybe_keycode' was declared here 265 | enum maybe_keycode maybe_keycode; | ^~~~~~~~~~~~~ cc1.exe: all warnings being treated as errors Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 12bc682cf9..e4f9588c3e 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -262,7 +262,7 @@ static int curses2foo(const int _curses2foo[], const int _curseskey2foo[], static void curses_refresh(DisplayChangeListener *dcl) { int chr, keysym, keycode, keycode_alt; - enum maybe_keycode maybe_keycode; + enum maybe_keycode maybe_keycode = CURSES_KEYCODE; curses_winch_check(); @@ -299,7 +299,7 @@ static void curses_refresh(DisplayChangeListener *dcl) /* alt or esc key */ if (keycode == 1) { - enum maybe_keycode next_maybe_keycode; + enum maybe_keycode next_maybe_keycode = CURSES_KEYCODE; int nextchr = console_getch(&next_maybe_keycode); if (nextchr != -1) {