Message ID | 20200707001036.1671982-1-jkz@google.com |
---|---|
State | New |
Headers | show |
Series | linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols | expand |
Le 07/07/2020 à 02:10, Josh Kunz a écrit : > Linux uses the EPROTONOSUPPORT error code[1] if the users requests a > netlink socket with an unsupported netlink protocol. This change > switches linux-user to use the same code as Linux, instead of > EPFNOSUPPORT (which AFAIK is just an anachronistic version of > EAFNOSUPPORT). > > Tested by compiling all linux-user targets on x86. > > [1]: > https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683 > > Signed-off-by: Josh Kunz <jkz@google.com> > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 97de9fb5c9..4ab9852600 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -2987,7 +2987,7 @@ static abi_long do_socket(int domain, int type, int protocol) > #endif > protocol == NETLINK_KOBJECT_UEVENT || > protocol == NETLINK_AUDIT)) { > - return -TARGET_EPFNOSUPPORT; > + return -TARGET_EPROTONOSUPPORT; > } > > if (domain == AF_PACKET || > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 07/07/2020 à 02:10, Josh Kunz a écrit : > Linux uses the EPROTONOSUPPORT error code[1] if the users requests a > netlink socket with an unsupported netlink protocol. This change > switches linux-user to use the same code as Linux, instead of > EPFNOSUPPORT (which AFAIK is just an anachronistic version of > EAFNOSUPPORT). > > Tested by compiling all linux-user targets on x86. > > [1]: > https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683 > > Signed-off-by: Josh Kunz <jkz@google.com> > --- > linux-user/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 97de9fb5c9..4ab9852600 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -2987,7 +2987,7 @@ static abi_long do_socket(int domain, int type, int protocol) > #endif > protocol == NETLINK_KOBJECT_UEVENT || > protocol == NETLINK_AUDIT)) { > - return -TARGET_EPFNOSUPPORT; > + return -TARGET_EPROTONOSUPPORT; > } > > if (domain == AF_PACKET || > Applied to my linux-user-for-5.1 branch. Thanks, Laurent
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 97de9fb5c9..4ab9852600 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2987,7 +2987,7 @@ static abi_long do_socket(int domain, int type, int protocol) #endif protocol == NETLINK_KOBJECT_UEVENT || protocol == NETLINK_AUDIT)) { - return -TARGET_EPFNOSUPPORT; + return -TARGET_EPROTONOSUPPORT; } if (domain == AF_PACKET ||
Linux uses the EPROTONOSUPPORT error code[1] if the users requests a netlink socket with an unsupported netlink protocol. This change switches linux-user to use the same code as Linux, instead of EPFNOSUPPORT (which AFAIK is just an anachronistic version of EAFNOSUPPORT). Tested by compiling all linux-user targets on x86. [1]: https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683 Signed-off-by: Josh Kunz <jkz@google.com> --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)