From patchwork Fri Apr 17 07:44:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yan Zhao X-Patchwork-Id: 1271935 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 493F1T0hf7z9sSg for ; Fri, 17 Apr 2020 08:55:23 +1000 (AEST) Received: from localhost ([::1]:40100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPDPk-0008LU-0s for incoming@patchwork.ozlabs.org; Thu, 16 Apr 2020 18:55:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48365) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPDOP-00071G-L8 for qemu-devel@nongnu.org; Thu, 16 Apr 2020 18:53:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPDOO-0000VZ-HR for qemu-devel@nongnu.org; Thu, 16 Apr 2020 18:53:57 -0400 Received: from mga02.intel.com ([134.134.136.20]:18259) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jPDOO-0000VL-7q for qemu-devel@nongnu.org; Thu, 16 Apr 2020 18:53:56 -0400 IronPort-SDR: w73bE0b4ckGwLW16Fg18OZ6KrytEsDkcUIs/DTQ0LGmbab5zQhrPUE1hfaaeZtwQbhlYcMmaoO D4qbCJ0yRtDA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 15:53:55 -0700 IronPort-SDR: 3TW7eSp7SQLZmXsX7nV7iMsZRJtGtoEfygQ4+XPKVScTldtCHM2ImoIIfOn/l1hCmQYu/EpuI/ bFvSW9Dx+clg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,392,1580803200"; d="scan'208";a="246130243" Received: from dpdk-zhirun.sh.intel.com ([10.67.119.121]) by fmsmga008.fm.intel.com with ESMTP; 16 Apr 2020 15:53:53 -0700 From: Yan Zhao To: pbonzini@redhat.com, alex.williamson@redhat.com Subject: [PATCH v4 2/3] hw/vfio: drop guest writes to ro regions Date: Fri, 17 Apr 2020 07:44:46 +0000 Message-Id: <20200417074446.28573-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.20 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , xin.zeng@intel.com, philmd@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" for vfio regions that are without write permission, drop guest writes to those regions. Cc: Philippe Mathieu-Daudé Signed-off-by: Yan Zhao Signed-off-by: Xin Zeng Reviewed-by: Philippe Mathieu-Daudé --- hw/vfio/common.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 0b3593b3c0..b6956a8098 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -38,6 +38,7 @@ #include "sysemu/reset.h" #include "trace.h" #include "qapi/error.h" +#include "qemu/log.h" VFIOGroupList vfio_group_list = QLIST_HEAD_INITIALIZER(vfio_group_list); @@ -190,6 +191,15 @@ void vfio_region_write(void *opaque, hwaddr addr, uint64_t qword; } buf; + trace_vfio_region_write(vbasedev->name, region->nr, addr, data, size); + if (!(region->flags & VFIO_REGION_INFO_FLAG_WRITE)) { + qemu_log_mask(LOG_GUEST_ERROR, + "Invalid write to read only vfio region 0x%" + HWADDR_PRIx" size %u\n", addr, size); + + return; + } + switch (size) { case 1: buf.byte = data; @@ -215,8 +225,6 @@ void vfio_region_write(void *opaque, hwaddr addr, addr, data, size); } - trace_vfio_region_write(vbasedev->name, region->nr, addr, data, size); - /* * A read or write to a BAR always signals an INTx EOI. This will * do nothing if not pending (including not in INTx mode). We assume