From patchwork Mon Mar 9 15:08:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1251626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48bhz874kSz9sPK for ; Tue, 10 Mar 2020 02:31:48 +1100 (AEDT) Received: from localhost ([::1]:44973 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBKNe-0006Mw-T6 for incoming@patchwork.ozlabs.org; Mon, 09 Mar 2020 11:31:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34474) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBK3S-00017C-3h for qemu-devel@nongnu.org; Mon, 09 Mar 2020 11:10:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBK3Q-0008Uc-PO for qemu-devel@nongnu.org; Mon, 09 Mar 2020 11:10:54 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:43841) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBK3L-0008RQ-IP; Mon, 09 Mar 2020 11:10:47 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MplPf-1jhdfT0Kcv-00qBcx; Mon, 09 Mar 2020 16:09:54 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Date: Mon, 9 Mar 2020 16:08:34 +0100 Message-Id: <20200309150837.3193387-31-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200309150837.3193387-1-laurent@vivier.eu> References: <20200309150837.3193387-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:6U5wEHkdFwT3kDr22VsD0fPTXG5OlUqnb2ZOctZu9kWAsabqMPX /lsz5U72zKPEX8SKZiKzfqb7OGburV/dBCDU6bo7WqyC+E8BPUckivUuhMEiR9HfOs9xcvi 4o3TFnrXxHanpwoOCuJcIGS2XD7qdFGKi1H1PVzXALWeT+4mnoIqJu2NExqZ48ue1LEvuyu +et7iqnwBNGqjOIsuHhCg== X-UI-Out-Filterresults: notjunk:1; V03:K0:EKnD7kcJ+Hk=:hC1YPwabFBImO5nS5mLgVl nOtTkJ7R+S3ycDX3BfxIEPA3JgfxL2pOuNqS7IxjKEVfmMWwvSY0uT93gdnPkRWF8tpmNovFO Fwfu8LfXuJSEPPs2/5qOa9MtOUgwvsew3t3Nx7wrSZ9nyqolYNR0cI9S8FEnLVFVOwDEZ5vlk h0D6/LVwym0nthv9tDfBNxLFlprKjjP5+juVlUWExS9ku5XY6FwYSgBF5oWdxJV8lAekbjUh0 Fb6L1znfPbLYn4K3ueM/Wu2Wi7PVOY9WgYIQ6s0Pd2DC7JyyBCR6LWhdOhFD6/rqxrbYVruQq LskQm3AbbJmbHlD7NUx4a64H+KvW1wQzSfcMdMxitVXIvbH6B+gNjBJ40FuX1BF6fyojFxfGV c7ndvWn755btxIE/2DnGq1xnq/tCx9lyixwWQ0u8D+h67fyJvnN7KkKSSoJgFhd/8Ryhaah1g rBMq672qGOnOSArZ1T0Dj0udF9pR6vxPsVNaOCQA7sLdRhp+nYZveycScl+TmDhq5fnFPiywx +3BtjiBGVElddVZeIwPKh8zhbVqyUed660ZlfPCh2tSuGdHyLsr7BT1JuElr/SsM3ar6Sy33Q N6Os1qQ+zkKE6KZ+zCMEy4d7sh/gz3cFfw+Mr9yOecL3/9IHIAmhqBq8CgfwM3m6g8zULo5cm cWYsSN9geXwdImFXBmpyVdqeHZRoVPHoHuO8C25M6wVLidzsoTT8zTc9gTHgvxnV/EtL5hfQy AjQrIaakojbf4pdXe0KDgAfA4sTVB5FJZNfjpZMsKaAE2TMQpa7HodD4bruCI1hyq2PCxQLmQ DTSNR2dBp78JRVgOPVkOsbs+O2Ybp6MnSdlzPTWe/I2EGnb8TrfSBphOWYsqtCuLBo9Ru03 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.13 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Helge Deller , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Michael Tokarev , Alistair Francis , Greg Kurz , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, Paolo Bonzini , Chen Qun , John Snow , Richard Henderson , Kevin Wolf , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Igor Mitsyanko , Laurent Vivier , Max Reitz , Aleksandar Markovic , Euler Robot , Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen = req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier Message-Id: <20200302130715.29440-7-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60f1..1c0cb63a6fe0 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest *req, uint8_t *buf) r->iov.iov_base = blk_blockalign(s->qdev.conf.blk, r->buflen); } - buflen = req->cmd.xfer; outbuf = r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) {