From patchwork Mon Mar 9 15:08:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1251600 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48bhf83KFYz9sPK for ; Tue, 10 Mar 2020 02:17:04 +1100 (AEDT) Received: from localhost ([::1]:44682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBK9O-00022F-9K for incoming@patchwork.ozlabs.org; Mon, 09 Mar 2020 11:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34138) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBK39-0000cY-3J for qemu-devel@nongnu.org; Mon, 09 Mar 2020 11:10:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBK37-0008DC-QM for qemu-devel@nongnu.org; Mon, 09 Mar 2020 11:10:34 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:52167) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBK34-00089Z-PV; Mon, 09 Mar 2020 11:10:31 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MVNEv-1ijVu8455z-00SLFB; Mon, 09 Mar 2020 16:09:32 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 21/33] hw/pci-host/piix: Include "qemu/range.h" Date: Mon, 9 Mar 2020 16:08:25 +0100 Message-Id: <20200309150837.3193387-22-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200309150837.3193387-1-laurent@vivier.eu> References: <20200309150837.3193387-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:haYMxJVRXzVW0hYOJCRTrEMLEtH4cwttsRRYvJAL/M1lUNCla+1 HCyndljMQ5dWOqyAn/mTV7An6tP6oGZ1qu4uY+cMOrrXs8yLQis3rKJILw0VX20Pp0liIpA scv0V69rv++UazF8zy7Q/i6rZcXxcPKLRhOyp/p1/tE5af8IUp8fbuqc6zBrcxXtE9QT32R Uh41WmmMnbrqy6QluAzfg== X-UI-Out-Filterresults: notjunk:1; V03:K0:PG9DHECbHZw=:w6hC1i9Mr2jROOLcIYZVhU Cs4t4l0MQMKJe5eIxLKy//Max3kmtwFbo2xim2sLdptA0wVuY9z3MI9SmqTgTa5Jzji41KWHc WawZYNaPfREOZHQULjXxjlOV7rW/TjZRN4wx+4uMh+DCHIRjUwu526wn8leI9xlIGdtuzH+aY 4H0/lgXCzfEhX8Mm40D77t78DiCOLgBjmeHa67IAh2TCkyMxQLCyKl+28bKKm99aEPwhJDhZt LYSGUFrZiit0TxPbzB0yprXQDUqfSNJlRVX/hqq2f2+MfYY4EohK578BlNgyRjmpW1KjwwaHB tGcjJLRzG9irhapv/7gTKweaRDaF1iNoDm8KlMF6cRtrUwJmyiCKgSQok0KQciBV+cq81izhr y0cFKvh2jb6s/BLGDtcO8h1Z9C89/sZf8ZIL7pA3ZPbkrs2RWD8hkZNOOT0lS5lpf01sdc3rP 1uGKCI3wryWzp4Nr4QNPVZNG1tLAflEFyzkDB+JduLTl4lzcZDUfR8THuYsgoPank9eEUqvvR Zl0qHuHMTRo3vOeARLptMjgx99tGElPKIXE/hxLmwenGdZUSGF6TWjAkWwzQFQu7O+rxQ4el1 g6PJYLXRfgJVW3uYKM/QR/2fFMHEpPg97efcVoNdHFSu7EXDVja4qB6flps/B5XtmI3mMMC9Y vynuBRDeeDeortGcRL2VoN24Bw+vsAD1bj+8Epb0ORHA4AioajzfttjCf9JscENxFkA4gwaq9 nilCplfreNpHoB0IBt3z1ie8tY4ZEgHuFwChqZV6VW+meONWC9azV+SGiYiUbViK/HEZ6q3lD 6k/D907N2oL0h3QgOyDrt0UzEaoJFzgnNr8F+KZH8uTKFv2XDsX1FINJelvdDkVQ1tcH8MA X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Helge Deller , =?utf-8?q?Phil?= =?utf-8?q?ippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Michael Tokarev , Alistair Francis , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, Paolo Bonzini , John Snow , Richard Henderson , Kevin Wolf , =?utf-8?q?Daniel_P?= =?utf-8?b?LiBCZXJyYW5nw6k=?= , Igor Mitsyanko , Laurent Vivier , Max Reitz , Aleksandar Markovic , Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé hw/pci-host/piix.c calls various functions from the Range API. Include "qemu/range.h" which declares them. This fixes (when modifying unrelated headers): hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka 'struct Range') Range pci_hole; ^ include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range' typedef struct Range Range; ^ hw/pci-host/i440fx.c:126:9: error: implicit declaration of function 'ranges_overlap' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) || ^ hw/pci-host/i440fx.c:126:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] hw/pci-host/i440fx.c:127:9: error: implicit declaration of function 'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration] range_covers_byte(address, len, I440FX_SMRAM)) { ^ hw/pci-host/i440fx.c:127:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] hw/pci-host/i440fx.c:189:13: error: implicit declaration of function 'range_is_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration] val64 = range_is_empty(&s->pci_hole) ? 0 : range_lob(&s->pci_hole); ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20200228114649.12818-15-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/pci-host/i440fx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index 11050a0f8bb9..d980c9704906 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/range.h" #include "hw/i386/pc.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h"