From patchwork Thu Feb 27 22:01:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niek Linnenbank X-Patchwork-Id: 1246129 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=SRxNIcER; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48T6953ZXqz9sR4 for ; Fri, 28 Feb 2020 09:02:32 +1100 (AEDT) Received: from localhost ([::1]:39036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7REk-0001CC-Ee for incoming@patchwork.ozlabs.org; Thu, 27 Feb 2020 17:02:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44928) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7REI-00018x-Qn for qemu-devel@nongnu.org; Thu, 27 Feb 2020 17:02:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7REG-0003ko-BZ for qemu-devel@nongnu.org; Thu, 27 Feb 2020 17:02:02 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:33450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j7REF-0003k6-6T; Thu, 27 Feb 2020 17:01:59 -0500 Received: by mail-wm1-x342.google.com with SMTP id m10so7951003wmc.0; Thu, 27 Feb 2020 14:01:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w9GsmGdCeDlovWnkHL5RzV48eH16cTZY3b9rQUOLBwU=; b=SRxNIcERCgH0LrWsW75smZfdKOtL2lX4ZYJvUBFMq3CNSr7xgFGS6nqUbtW2O4hYm/ GncxLJVBpL1pkTQqU8Ms6BDHydE8t70w8rrXNv1KtRFDQCohKpTMKSjzCUYAu0SfI+aH xk/S51ufxF4CRMEUoJbPBdP69eXGP3oTEbPcrZsONtJHn6ClbTp5OUoR9/2h4kMwOts2 xEQAKmUfdydcOc1qEAPI0WPwSOnZEJaPu60E/gn3f5/YSBYKM4fmB0qnonn9nn3b+Im4 eN8enXMq/aPB8uhPknZPvPsVZ6ASYRbNL+L/mCztm/FKJmFrbvPw08D+uIwc4w+NNFwc nIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w9GsmGdCeDlovWnkHL5RzV48eH16cTZY3b9rQUOLBwU=; b=mFTOPQCLexVe7IuRwzCC/Q00XlfyCH2NV1vSQVDL7gDJXaNEGdNJqD5US6RYvi/nYS Ls0Lk3TNuAFqRB4gbDoFkYf4NrMb0gnYdU04JPskb7aMHoF4Au8BAyB57TpV+Tt9bKNb M3RoecPaRtaIGYn1zu0uLoOELlzaR6pXjwCXsV7es0Aj1DjJafgbdVY9PeVJl4snOth9 tRtyjgUlvj9hZD36JErmiONi4zDH5zuKYU6X9KXBu63kVkcmPFaVGlcL5mOsHoz7Ev/w lRUitjPfQzlpPKUWnKg3GWqIgUJUyhqqfipbSvl1aZJ0Fl9FDFpLjBvZ9GqSM/S7b97/ Sj5g== X-Gm-Message-State: APjAAAXGUBGzpkm26xIJ8YQu9xHctiKxOILqfvrn3LPzkAYObj9X8sB0 GtY9/xz8seTTh5ustZroPrLvcrFA X-Google-Smtp-Source: APXvYqzkvXHwyxUWqTLeAnLIDGswJN6riHMajmUwLdI9F+97U8m/u2kjKFWg7oxvywN8fFgFurq0UA== X-Received: by 2002:a05:600c:2107:: with SMTP id u7mr884038wml.54.1582840917494; Thu, 27 Feb 2020 14:01:57 -0800 (PST) Received: from pavilion.home ([2a02:a456:6be8:1:8edc:d4ff:fe8b:18b7]) by smtp.gmail.com with ESMTPSA id z14sm6447040wrg.76.2020.02.27.14.01.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 14:01:56 -0800 (PST) From: Niek Linnenbank To: qemu-devel@nongnu.org Subject: [PATCH v1 2/4] hw/arm/cubieboard: restrict allowed CPU type to ARM Cortex-A8 Date: Thu, 27 Feb 2020 23:01:47 +0100 Message-Id: <20200227220149.6845-3-nieklinnenbank@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200227220149.6845-1-nieklinnenbank@gmail.com> References: <20200227220149.6845-1-nieklinnenbank@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: b.galvani@gmail.com, peter.maydell@linaro.org, Niek Linnenbank , qemu-arm@nongnu.org, philmd@redhat.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The Cubieboard has an ARM Cortex-A8. Prevent changing the CPU to a different type which could break user programs. Signed-off-by: Niek Linnenbank Reviewed-by: Peter Maydell --- hw/arm/cubieboard.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/arm/cubieboard.c b/hw/arm/cubieboard.c index 0195925c73..010375f0a8 100644 --- a/hw/arm/cubieboard.c +++ b/hw/arm/cubieboard.c @@ -30,9 +30,17 @@ static struct arm_boot_info cubieboard_binfo = { static void cubieboard_init(MachineState *machine) { - AwA10State *a10 = AW_A10(object_new(TYPE_AW_A10)); + AwA10State *a10; Error *err = NULL; + /* Only allow Cortex-A8 for this board */ + if (strcmp(machine->cpu_type, ARM_CPU_TYPE_NAME("cortex-a8")) != 0) { + error_report("This board can only be used with cortex-a8 CPU"); + exit(1); + } + + a10 = AW_A10(object_new(TYPE_AW_A10)); + object_property_set_int(OBJECT(&a10->emac), 1, "phy-addr", &err); if (err != NULL) { error_reportf_err(err, "Couldn't set phy address: ");