| Message ID | 20190906165736.5612-1-jcmvbkbc@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | linux-user: drop redundant handling of environment variables | expand |
Le 06/09/2019 à 18:57, Max Filippov a écrit : > QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to > do it again in main. > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > linux-user/main.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index c9d97d2b1fc6..22ae2b3e65d1 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp) > > thread_cpu = cpu; > > - if (getenv("QEMU_STRACE")) { > - do_strace = 1; > - } > - > - if (seed_optarg == NULL) { > - seed_optarg = getenv("QEMU_RAND_SEED"); > - } > { > Error *err = NULL; > if (seed_optarg != NULL) { > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Le 06/09/2019 à 18:57, Max Filippov a écrit : > QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to > do it again in main. > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > linux-user/main.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index c9d97d2b1fc6..22ae2b3e65d1 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp) > > thread_cpu = cpu; > > - if (getenv("QEMU_STRACE")) { > - do_strace = 1; > - } > - > - if (seed_optarg == NULL) { > - seed_optarg = getenv("QEMU_RAND_SEED"); > - } > { > Error *err = NULL; > if (seed_optarg != NULL) { > Applied to my linux-user branch. Thanks, Laurent
diff --git a/linux-user/main.c b/linux-user/main.c index c9d97d2b1fc6..22ae2b3e65d1 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -701,13 +701,6 @@ int main(int argc, char **argv, char **envp) thread_cpu = cpu; - if (getenv("QEMU_STRACE")) { - do_strace = 1; - } - - if (seed_optarg == NULL) { - seed_optarg = getenv("QEMU_RAND_SEED"); - } { Error *err = NULL; if (seed_optarg != NULL) {
QEMU_STRACE and QEMU_RAND_SEED are handled by the parse_args, no need to do it again in main. Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> --- linux-user/main.c | 7 ------- 1 file changed, 7 deletions(-)