From patchwork Wed Aug 21 11:19:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1150795 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46D5Nc2nt8z9sBp for ; Wed, 21 Aug 2019 21:41:52 +1000 (AEST) Received: from localhost ([::1]:47270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0Ozu-0003dT-AT for incoming@patchwork.ozlabs.org; Wed, 21 Aug 2019 07:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53475) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0OfN-0004wA-3q for qemu-devel@nongnu.org; Wed, 21 Aug 2019 07:20:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0OfK-0006Zh-RA for qemu-devel@nongnu.org; Wed, 21 Aug 2019 07:20:36 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:55141) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0Of2-0006MV-KP; Wed, 21 Aug 2019 07:20:16 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mqrjz-1idq8i1ebZ-00mvpD; Wed, 21 Aug 2019 13:20:05 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 21 Aug 2019 13:19:40 +0200 Message-Id: <20190821111947.26580-8-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190821111947.26580-1-laurent@vivier.eu> References: <20190821111947.26580-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:i+3b3qlR6kyQgu6gQfu96rxZj7K07Flpi6sw/j0BgOY8QwjhaRL FLLPkCl5BEfqwz5dQI5OsOlUnlrfaUy4i5pPqfWeF5wrf018FvTB08mNMgnnMEnDrhWVa/J IYjFmHpNmRZRXJjEypFI0uSbL6vK83oYIaxMpETydGePHENw/6DYZWycUAfct4xsLPi5GyG P50TxSivcFVqbYY8Qy0KQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:/lz0sZuo1ps=:qu6e8G22GTbs71/edVKvng U/Dy36pjAJMQojsfEnHkTrU0uJ3MNI0PTN/1Ph4pJjaNVf3oVDceaoOXsy0UJuR0t0rEzwqy7 ODYKWm67rOGNUGRxh3DTl46uaIYvGDx4rBri8x1tT5xVE3BxAn58bQpm/rzRXJGAxgsCGH53w U3FKHIktqi9/tUNJnFHnnoWEJ7/6b42XL5uaAWDJ9LrXmyxPvFzQIe8k0NXifBOd+QFZFH2rk GmFOubWF584hkrayFPlAc6D6hR3+jInQ0/Mc3uimC3Sv1N0wU45z3CFU/F8jru4JoWFRH0Ihp E0cpzdNitUwTtLCi6QUqxhI5NzS2UrvDnYD93qS5YUKubmpBphg9n94gMv82pwpkxOMpfFd02 4DFbcI87G4JGHhpVaXRdMZ+GMgC15lJCi5EWSpoTVYke3qsgvkUo5vLcd0uMJrKSZN7ErT4Zc GTBGpEMxFqhucRwpbCy8U6qVQVoKcKPeu85MS2NTO8+ZksoJWTpUhGA5ULiQ3Jf4Bnt9r+laT XsQ1XTv+VLA47zXgDEYtCZBS8fc8lMLszuGmEFEwOuW4Kwqt7aMgk1jU0XIBt+QZ7KEm19vzE ea/AMVOtThxx2GF0d5QrXCnpzFD2Gc661yw4OlDEMonLTES3Gn+Rv6E9s+Z5H090jeu0HcOZ7 fVEzdGgvan7j2pBH16iXtlbgDJD3IkEfS3jLEbDmARq67U47Ph4NcXfCSSJKZ42ZBsbyyeq8K gAXYc9aiarjQVL3qWb4O0BSGT0GxhL2gLc3nOQ4KH3vMV1DUKq/wPb65nj810hiyN8+LoNI/5 cXiuGrIcuBHDE38b2pPz3XBNh60vw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.24 Subject: [Qemu-devel] [PULL 07/14] json: Move switch 'fall through' comment to correct place X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Corey Minyard , Juan Quintela , qemu-trivial@nongnu.org, Stefan Weil , Jason Wang , "Michael S. Tsirkin" , Michael Tokarev , Markus Armbruster , Laurent Vivier , qemu-ppc@nongnu.org, Paolo Bonzini , David Gibson , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Dr. David Alan Gilbert" , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2: qobject/json-parser.c: In function ‘parse_literal’: qobject/json-parser.c:492:24: error: this statement may fall through [-Werror=implicit-fallthrough=] 492 | case JSON_INTEGER: { | ^ qobject/json-parser.c:524:5: note: here 524 | case JSON_FLOAT: | ^~~~ Correctly place the 'fall through' comment. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake Message-Id: <20190719131425.10835-2-philmd@redhat.com> Signed-off-by: Laurent Vivier --- qobject/json-parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qobject/json-parser.c b/qobject/json-parser.c index 7d23e12e3379..d083810d3782 100644 --- a/qobject/json-parser.c +++ b/qobject/json-parser.c @@ -519,8 +519,8 @@ static QObject *parse_literal(JSONParserContext *ctxt) } assert(ret == -ERANGE); } - /* fall through to JSON_FLOAT */ } + /* fall through to JSON_FLOAT */ case JSON_FLOAT: /* FIXME dependent on locale; a pervasive issue in QEMU */ /* FIXME our lexer matches RFC 8259 in forbidding Inf or NaN,