From patchwork Wed Jun 26 20:02:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1123000 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45YvBV6t5mz9s3l for ; Thu, 27 Jun 2019 06:04:28 +1000 (AEST) Received: from localhost ([::1]:44668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgE9W-0007p7-Ty for incoming@patchwork.ozlabs.org; Wed, 26 Jun 2019 16:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34994) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgE8e-0007n6-GP for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgE8d-0000z3-BV for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:28 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:38095) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgE8d-0000yS-2T; Wed, 26 Jun 2019 16:03:27 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MStKq-1i9KEJ1Vvi-00UM6S; Wed, 26 Jun 2019 22:02:57 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 26 Jun 2019 22:02:49 +0200 Message-Id: <20190626200252.30220-2-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190626200252.30220-1-laurent@vivier.eu> References: <20190626200252.30220-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:VjQsvc3d06qk9A6m95K7upSTC3nFZciaQBjZZHSxsd0tChHc7DE oJNZCMn7zyS+gmIwOYnMjvpFnb8FdxY1/FmDVxmqE/kXPEEoZBc/lDkhBzpkTCdzPPVqSWL QV5l7Ck5eTblDtEXAH+E9tN61aZT1VmxQStVq/86GsvlJTu4dRt/Tczq+K2nzIQIAtOrF8a T1zgFrzMoU/ucERCixpYA== X-UI-Out-Filterresults: notjunk:1; V03:K0:6hxK8KwUclA=:Jy4o4P0WB88lpsBLkqddS5 59+OVsrcy2ea0ODCcoaSQvsLz+6KFbgKL3EH/GcX9dk1tjYaSwQMYCwYsyH0MmdjEsswoR/Wt eFEBPbp27XtBhhmrvmAIDabW0f4DY9TiFWyQUgKPt+xoRrgEZsRhkZUn26O6W3P7coD9g4yD2 zihb1Xt6i3XGK9jTud0hp0wAiChKJJU3/4jkHy9ouGQlE9uUSZqH9CME/pxaOvpU9riR3Ngjl +WFAHy77DA7KNpFUWNdgXncttTFiJUkzAAK+IcAUWKDIXWDjpq/O8IuI/7qXhcBzcsonovnb6 JQg0gCTzMuzionTqNo8DVRWP570RuzJJyShdvRawSg0oabWlAHO3Qg5nLUckokCuOBUSE61rW uFVyVi/I3sXI48s+0JbB4Q7IIvPHfFHV78CFSYmE4N+o+M6h+Xsq5TCQKC3p28OA4ANONKBkn 06EeofKpPKaoRQPmSGGCzlwt+N16dW7G8h2yPoZJqO7U7OxP8WF1VB8TFHU+e9yfLAkm77bsW t/ag3oe56Ydw9gsFMiv0I1CZHxSE3dFFNy4ZcJifIEnxiCwciXX2QRdXI20ZSJ5A1UWCtETvi mvIb+xnm9gdd5X5IzX0L2PBApMukUclyblHvosE/Z8t9vmBxuD7xFqMoA582BloHjmEIV+RG5 6d0AcqgHB7yXNpBNALfbvN81DVqD631IPMz0izHWIEB/9UzW9Hk+zo6SmUkV/gzauMcbGKcM9 zDJ6AGBKv88+CY5rxQwrYnqWqaZlGNmQi2eeew== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.24 Subject: [Qemu-devel] [PULL 1/4] configure: set source_path only once and make its definition more robust X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Antonio Ospite , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Antonio Ospite Since commit 79d77bcd36 (configure: Remove --source-path option, 2019-04-29) source_path cannot be overridden anymore, move it out of the "default parameters" block since the word "default" may suggest that the value can change, while in fact it does not. While at it, only set source_path once and separate the positional argument of basename with "--" to more robustly cover the case of path names starting with a dash. Reviewed-by: Eric Blake Signed-off-by: Antonio Ospite Message-Id: <20190526144747.30019-2-ao2@ao2.it> Signed-off-by: Laurent Vivier --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b091b82cb371..b6962d1381a5 100755 --- a/configure +++ b/configure @@ -276,10 +276,10 @@ ld_has() { $ld --help 2>/dev/null | grep ".$1" >/dev/null 2>&1 } -# default parameters -source_path=$(dirname "$0") # make source path absolute -source_path=$(cd "$source_path"; pwd) +source_path=$(cd "$(dirname -- "$0")"; pwd) + +# default parameters cpu="" iasl="iasl" interp_prefix="/usr/gnemul/qemu-%M"