From patchwork Wed May 29 06:41:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1106823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="llp7jX5j"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45DLnN3z5Xz9s7h for ; Wed, 29 May 2019 16:45:28 +1000 (AEST) Received: from localhost ([127.0.0.1]:48236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVsL0-0003LY-Hl for incoming@patchwork.ozlabs.org; Wed, 29 May 2019 02:45:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVsHm-0000y6-NZ for qemu-devel@nongnu.org; Wed, 29 May 2019 02:42:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVsHl-0000HO-Kq for qemu-devel@nongnu.org; Wed, 29 May 2019 02:42:06 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:53158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVsHl-000065-DI for qemu-devel@nongnu.org; Wed, 29 May 2019 02:42:05 -0400 Received: by mail-wm1-x343.google.com with SMTP id y3so723688wmm.2 for ; Tue, 28 May 2019 23:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q93fkAMrEvzu0zyZkj4+7iBrZF/eUh2AH5ITql2fAuw=; b=llp7jX5jrtS228xwaO7CXpp8dgXz3frK0rn/LRAoYrnuVUsosdvEFU8vHf6DFbL8lB lEXUjyHt5u6J+5dw662Au04mJLshd2gNfulzSiZlBWJT5TLScvwO0iOEAOs40DZeSXGM q5LhY9meWm4P2lQPxCvpOVODgn46AwwMtoVaHn6WxqIzYPmyXWb0+5c4lyCGB3Nb/+z8 mnhxTtfyufB4GKuZsqldDm9dvsblZZRlY0Ne5RwCoXx6pZTj4KudYJb1hDkx+nGdTA7t ojKGZ7JO9qM3VIYq0Riy+PreIFdDrMZsFuA+2dzEScEEm7eo+HYGtve3jJhwxAa8pZdB c3ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q93fkAMrEvzu0zyZkj4+7iBrZF/eUh2AH5ITql2fAuw=; b=RQ2JN6MSFUyywcJbTeU7U8VoNynNUiXOA0nxYCt4TerLAJA5ePm8hJ8BIhQptrl7NY PVWmWPEzFBJkbbqE+M/vS8qIZF6aCOGtIq+etDS1cAgLms1pAMZrXFNsG7JetRCH8F+G 7VOvDAUvoRelBkGMAZ9Rlu0l/Xqo9YKI7VWEONVUVIFWYNwcTSYpg4/cN6wY7k3rENXG mKdTKxxS6G3edMtAMdqgLZ3hPBK8d32AuzC3fMfM8aXzJb4jVrH5OMeIUwB6vP8t13pp pGzPcWjMmG85xcdeRSfmzT/ZrXhYFmRx3TNsGxTNX3Tbkdvb6jP9D2q/Vyc/KC/pai6t QHPw== X-Gm-Message-State: APjAAAXzTftRcMyqhUouXnQdojA9GVcA2pyuEY+583cQQ2cuPPRN8zB5 J6/FsM79X7bYVxLUCQ3rKlmairuI X-Google-Smtp-Source: APXvYqyD7lHuGhAPQV8e/oWvtZp59igvCuLeewguQCECWrSZdQIC5OGPCL6bAzUbEIKOsZd2FelBJw== X-Received: by 2002:a7b:cb84:: with SMTP id m4mr6043579wmi.50.1559112124271; Tue, 28 May 2019 23:42:04 -0700 (PDT) Received: from linux.local ([31.154.166.148]) by smtp.gmail.com with ESMTPSA id f2sm6831168wme.12.2019.05.28.23.42.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2019 23:42:03 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Wed, 29 May 2019 09:41:31 +0300 Message-Id: <20190529064148.19856-4-arilou@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190529064148.19856-1-arilou@gmail.com> References: <20190529064148.19856-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v12 03/20] gdbstub: Implement thread_alive (T pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron Reviewed-by: Alex Bennée --- gdbstub.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 1db322c15a..7801f2f260 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1507,6 +1507,30 @@ static void handle_detach(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(s, "OK"); } +static void handle_thread_alive(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + CPUState *cpu; + + if (!gdb_ctx->num_params) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (gdb_ctx->params[0].thread_id.kind == GDB_READ_THREAD_ERR) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + cpu = gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[0].thread_id.pid, + gdb_ctx->params[0].thread_id.tid); + if (!cpu) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1807,17 +1831,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'T': - thread_kind = read_thread_id(p, &p, &pid, &tid); - if (thread_kind == GDB_READ_THREAD_ERR) { - put_packet(s, "E22"); - break; - } - cpu = gdb_get_cpu(s, pid, tid); - - if (cpu != NULL) { - put_packet(s, "OK"); - } else { - put_packet(s, "E22"); + { + static const GdbCmdParseEntry thread_alive_cmd_desc = { + .handler = handle_thread_alive, + .cmd = "T", + .cmd_startswith = 1, + .schema = "t0" + }; + cmd_parser = &thread_alive_cmd_desc; } break; case 'q':