From patchwork Tue May 21 09:59:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1102668 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YrdPF8Pl"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 457Wl843Ztz9s6w for ; Tue, 21 May 2019 20:11:48 +1000 (AEST) Received: from localhost ([127.0.0.1]:50611 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT1kI-00058K-C1 for incoming@patchwork.ozlabs.org; Tue, 21 May 2019 06:11:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT1ZC-0005lV-4b for qemu-devel@nongnu.org; Tue, 21 May 2019 06:00:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT1ZA-0007Za-7c for qemu-devel@nongnu.org; Tue, 21 May 2019 06:00:18 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:41507) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hT1ZA-0007WB-1S for qemu-devel@nongnu.org; Tue, 21 May 2019 06:00:16 -0400 Received: by mail-wr1-x442.google.com with SMTP id g12so17568063wro.8 for ; Tue, 21 May 2019 03:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CctE0zTJnEU25JB3cn3PPMbvqOEdGic49XPgJHQGWnY=; b=YrdPF8PliS9s5JYhwNFYHFvT5KIgys3HchqYGIx7RLg6N26WLvQtZAGobSgfT8TeyU nxKkCEfpwKjAXYRS2sNF2yac3yiKHk9/djX2yYK73R+bwz3L1nXaSdndM4toOucAtwgS kSYVFFOWSj56bNy+jGK97ok+Dq1m9CbPLIsG6IopNTe9E+PBR0lm8RE2LYOjsrE9gdOl d2MXhiGGPKBy5vWU9d391D/YFSfLUevjlSSrA+cAkIHqRgMxczGf1fQnhaH0KJwTwjXG hs0zgtS02nw1eufo8nTsO6a09gmLcFaEMWNcHkFzA/Wt6gjuCOqbfG+KfuBiWnknhIfw QVrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CctE0zTJnEU25JB3cn3PPMbvqOEdGic49XPgJHQGWnY=; b=PRjw02gZ9aasxU6VlQ48dcRhR4XnFPRUDIfDfAU3rHlaOTxE/VPgjIlrU1Zc1GpUVr wj+2qcbf7SNjazZGiY/Wgi7S9gMAmmVznrcfUdeA+CGWsSKyQKm03yY25EqprAjZgEwj MDkM7/rv8/dr/rkW3pvGqjq4zND/nfN017Qw9Lx/vrODBFZgI2IWKpLOlapckH3o0u+c hTjWoXyC9L0tkOwKJLIsTNWMVgTRj8omLjpnTcOG/RxlGFlnKL472QCt/sxavDBqivlT WWG123/eXiNXXg2QpCj/ihkl/1ttXrFQ7xbooWPIcj6Sf4kfuu7VlCxKcqHVn+Yg/XuG Q8wQ== X-Gm-Message-State: APjAAAVEww2VRDxVePsKIMweUeVrprQclmPTM4wK6Cimj6y3Ww8TgCWr iinqZQTxq93IbWXFAg5d40HypmTI X-Google-Smtp-Source: APXvYqzTJGEfkiXUIEEGRWsk9Cr5H9IfkL2uC3r1SnjGOji49poKC4bLGc1GIu84YrLBrDgAeaZH7A== X-Received: by 2002:a5d:5283:: with SMTP id c3mr10548303wrv.268.1558432814428; Tue, 21 May 2019 03:00:14 -0700 (PDT) Received: from jondnuc.lan ([176.230.64.64]) by smtp.gmail.com with ESMTPSA id 65sm3080257wro.85.2019.05.21.03.00.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 May 2019 03:00:13 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Tue, 21 May 2019 12:59:36 +0300 Message-Id: <20190521095948.8204-9-arilou@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190521095948.8204-1-arilou@gmail.com> References: <20190521095948.8204-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v10 08/20] gdbstub: Implement set register (P pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 39 ++++++++++++++++++++++++++++++--------- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index c59a6765cd..1c210d671a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1637,6 +1637,27 @@ static void handle_remove_bp(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(gdb_ctx->s, "E22"); } +static void handle_set_reg(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + int reg_size; + + if (!gdb_has_xml) { + put_packet(gdb_ctx->s, "E00"); + return; + } + + if (gdb_ctx->num_params != 2) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + reg_size = strlen(gdb_ctx->params[1].data) / 2; + hextomem(gdb_ctx->mem_buf, gdb_ctx->params[1].data, reg_size); + gdb_write_register(gdb_ctx->s->g_cpu, gdb_ctx->mem_buf, + gdb_ctx->params[0].val_ull); + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1881,15 +1902,15 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'P': - if (!gdb_has_xml) - goto unknown_command; - addr = strtoull(p, (char **)&p, 16); - if (*p == '=') - p++; - reg_size = strlen(p) / 2; - hextomem(mem_buf, p, reg_size); - gdb_write_register(s->g_cpu, mem_buf, addr); - put_packet(s, "OK"); + { + static const GdbCmdParseEntry set_reg_cmd_desc = { + .handler = handle_set_reg, + .cmd = "P", + .cmd_startswith = 1, + .schema = "L?s0" + }; + cmd_parser = &set_reg_cmd_desc; + } break; case 'Z': {