Message ID | 20190503112654.4393-4-laurent@vivier.eu |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wVQc1zvXz9s3Z for <incoming@patchwork.ozlabs.org>; Fri, 3 May 2019 21:34:14 +1000 (AEST) Received: from localhost ([127.0.0.1]:38558 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1hMWSB-0004Sn-Eo for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:34:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <laurent@vivier.eu>) id 1hMWLf-0007kD-Op for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <laurent@vivier.eu>) id 1hMWLe-0003Lj-R4 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:27:27 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:41031) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <laurent@vivier.eu>) id 1hMWLc-0003Hr-J1; Fri, 03 May 2019 07:27:24 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXXZf-1hFhg93Xnr-00Ywj9; Fri, 03 May 2019 13:27:03 +0200 From: Laurent Vivier <laurent@vivier.eu> To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:26:45 +0200 Message-Id: <20190503112654.4393-4-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503112654.4393-1-laurent@vivier.eu> References: <20190503112654.4393-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:Vwma6Rzlj1kjDOfuerTs47edBiyFSJN5reaPmOSAYvp+eeoE27q z7EK4W3bbUHt68eLqFhPcwTWR5qMBgnVQk2GCgwd7h4KbQSfUZVMUh9YcekhNZhicQYbIta kf8MJVWBrtp/CJL5KfwNilVi+VSgI5Extlxd8CWU/oFYmZf98UUJb87WyzQIIEbkGSuUq4v C8yVoT+erKbxXgJ4En/oA== X-UI-Out-Filterresults: notjunk:1; V03:K0:IfgB+E8W+KY=:tPvxorVaOzTttZtQOwl0Vm AUBoMI6dZ0YqIRGyqLuQ01qCXYAp5k9fl+o2Uno3tnaTuRg+WhcjCeS1X1oslG0BApq+kkKsk XFeHszHpSWVMkaUKi0kTw6AFFyjh7Zf2YSVtyIgC7owhYk+uji124tIvosY2KGpDt1UMqLY1X oQlnmISEmQL7kmLU78LxWrM3KCtvS3yjtgztYZxXRlYM/4hnmz2+xCu2UTvplohpMrrEeuBVv gPjZKUcDw2kC2wo8014cYtOG/o1apYXrQVbuY2YzgktMZ1J4Ryyz3HvXaEiAclaolbcHso2hg 8/n2smotmkV551YbPb259USzGMsIivJFwfxWSrqlj+ivwPIq3jWks14MHRP1ZKijek78h9qX/ fMQm6Z5kkaiBtB4K0KtYYGxuzmOVEm3Fuivw97x49ctDM6/U0Oj8Sl4o6psM38bUochVwZiDL BuMbxitEuKDjhu1C0CxrmGrHOkQaQzvhZhEZ7QATHlI2d+6EO/tlLU8Rx7rrjpTjQRIfm5Xp8 vqYuOV9CbBnVKLY0q0yFhuYMMZxtH6HjhYSBnWdApeAe16ThHU4NzWD4iwqH2B904XQKTSkZP wFiZALze0g6EBLj1AmEKSK0Y+7VTxDzkUQdv10EbM6ge8A+ykbzwCB7CFG/iYYmU7CXb5idTJ 26WJwDc6+UHqVUuuxwtujuveJpZpW+RRnReNW6MM525R0PJGPMsiYVwIXR++hp+5ZtaeC8CAr q1Ee8Fuwd1uXO8nm5m6tdV9Krwccsv4R/qb0HeLcs4VSWWBS/YJCTLo+VcQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.134 Subject: [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Jason Wang <jasowang@redhat.com>, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= <philmd@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>, Fabien Chouteau <chouteau@adacore.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Wei Yang <richardw.yang@linux.intel.com>, Gerd Hoffmann <kraxel@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, =?utf-8?q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, Artyom Tarasenko <atar4qemu@gmail.com>, Richard Henderson <rth@twiddle.net> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,v2,01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf
|
expand
|
diff --git a/CODING_STYLE b/CODING_STYLE index 90321e9c2821..cb8edcbb3692 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=',