From patchwork Fri May 3 11:19:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094840 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wVNH591bz9s3Z for ; Fri, 3 May 2019 21:32:15 +1000 (AEST) Received: from localhost ([127.0.0.1]:38544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWQH-0002n6-IJ for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:32:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWEw-0000XO-KK for qemu-devel@nongnu.org; Fri, 03 May 2019 07:20:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWEv-0002LL-Kg for qemu-devel@nongnu.org; Fri, 03 May 2019 07:20:30 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:36083) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWEv-0002KB-C9; Fri, 03 May 2019 07:20:29 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N2m3G-1gbPDa3EFg-01346I; Fri, 03 May 2019 13:20:11 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:19:49 +0200 Message-Id: <20190503111958.30825-4-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111958.30825-1-laurent@vivier.eu> References: <20190503111958.30825-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:pKsN4+cluC+r1rmhDvMgjMvs/XYsPlaoMp8SyHySKqZejIZkDA9 TYrZgIRGOhIV2jswJ2BAEajyAJk1hFDUJwGnCv801u/lOk4zyAQmBQDTYm04ZqNL5mDE90p m0clE4IdV3ENr/FvsYb6bsNyCXupboqIKsovooVmp9WAn+lvziFm1aZYcRPLT4X04UGxyZG 0bkXBO0oD4i9d822EZ9lQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:7pjqB3X4dFY=:NWCUEDvJCZHyzQSMg2SBiw 1fHilwJ/onNDhoF/rwSx1l1z/P567pSI+cwGVzmgxRdXvhrcNSvygoltiHLbuRAqKDdNP5eDL MLnhKRqIa5GwuwG3dXJuEpekGxJ2N6UzleCY6iH4WRlVty09IoGK4itn4mqV/FaOd91suI7Fn JsZ8SBnkM5nRQVxKRT1NGkybNQHvYTrZlX87Jh5e3nLPTMKdYYbk3tmxHbNUoYLJafcVZgbjC 3Oz7qduSEX4yGqRoEfrN6mNrPVbmIcisseDZpaeg5kETLxX5wQ4LvPKf8Drv0CISzjLRnKa7m mdAmSJ0g2ZhxjXomdnlBoWSScEapTfkwJxwMXPOTXAL6V+B26GlEavceTIIB0SprgHdr+Ft05 Gd7JeqIBz3kp5dMDEp1cEI/M/lhRveWpAGNTlWE5MDARBQVOPtkOpHzppw/5b3y6wQFpSkO3r L9EjJ6KXlMpTcZGE6RINu7xj6ohsQGps7/kVSHIXTv3R6Ii4+I6HVMuZAuVNb6VLIDf9yEIzQ QnohH1T4f7ZYGp1a/xkILd+2AsfjsrOzcXooOKOO8+IQLeveLrDznSsin6gpXjbOJ4xGJN4mM tmdlqjsK/4szs6pc2DM3Z6LpNskLefU6acleGU6DSjBowymGK2FK2MIv7/OIcnxD8usPi19Gi hqqF/qtr+hUHl1b1aSoGzAm+jWBt00EHA+OKRjqhxSEex0bssSiSNe1D4pOMJSyCVTCsYehaF mfO8lJAJkflSpTHK6+d59JCtDto0dbt+Gvf3KWirpLrXXBL+PiN3FJ/2+vY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.73 Subject: [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Stefano Garzarella , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-3-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 90321e9c2821..cb8edcbb3692 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=',