From patchwork Fri May 3 11:18:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wV7W1lgJz9s4V for ; Fri, 3 May 2019 21:21:11 +1000 (AEST) Received: from localhost ([127.0.0.1]:38323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWFZ-0000Ff-3k for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:21:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWDv-00085r-FK for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWDu-0001Am-Ht for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:27 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:40219) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWDu-00019Q-8x; Fri, 03 May 2019 07:19:26 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M8C8J-1hRl140LeF-005LgM; Fri, 03 May 2019 13:19:01 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:23 +0200 Message-Id: <20190503111832.30316-4-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:r+Vs6CZi8JNSFr8YokVIJ911RTcHv7fk6gLBqkk4BiIkk0vPIv/ mYR7ejTgx0HvCDNHZ+QwH5uUenYpyzUk8DtnaewHB4MSr2V9IcoeHNtCUnOnpodFIDnpAcX NOErDHKNHS5kGTl7YcQc82uqj+P58pF5Ok4TfqQ1a2tom9fuNTAWuUZLA5AmWAV9CdiR6uJ OxjczUFGJFB7Nhd801n8A== X-UI-Out-Filterresults: notjunk:1; V03:K0:zM+h+jotzoA=:ajt76nf5ZJpNMR5fH3HiEy 020n9ugWQ2TVITlQpm37Wy68gDZ1wsQ7fxxd7KgDKa7ocrXrlIkfrHT/CCZyJEWS8WrqoOx69 DFGJRgmywtED+JfUaa4v3F7xOgRI6Ef+5RVesr1rhysfQKbG6IboI43m/oxjFiay4oheKxcA4 3wZdYnVGrNj6ycAZFXBdK82eDXkV4A3tYQdBNTHOyoBQSPcDA0m0XWUxfGhUYTxDSVwfLTHE7 nDVYYdcuEWsagw30aAMQwcbscq4TMm6JpRIClAtl+F1jvZdEMQc0640ra/7OqzeYQwLWIzr55 zrcI5v3ILsRbomqOSD/aumnqbdjhwWeB7bGXbyikhqRgfDtMxqT+E6L0XyTV+oSxJAzhMBaZ9 vRkYeEvBzq/1JKMN5na5DxLpAjS9x8H3mDpV7jrfwALJsQD8m9gG/Sys2Ct/QaxkBsbwbrtuA Y863va83QAHQt85IWBUpQQGPGjz1F5EhRWs5IkyUcB9R/pPn6s7BzqcqaWGlbOXJsTV4GWZUj Ou3Gx7ETeofKzgQNyAvJVmHm8rzju082XYxciHth/XAlzCC6TnK8uJPTSBiOFsGZYULXhxqBU Xs0tohtHA/ieXf4ck2xJ1zq6fqpBij9CTBGaktP9pANhnfOCNyl2lW0nfGmnTmvWPPxEO/1az A8zI9icavVfpq8awdrX8jaZEREbIUD8vorunmsE3palp0eqLi4ssYVT0fszRbi8sqtuqVGXkq U85BeS3qqR3kEDQxInraYa8sof3AOMyNsvr4+NqvbtFB2QPFVwJJIiP0OUQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.134 Subject: [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Stefano Garzarella , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-3-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 90321e9c2821..cb8edcbb3692 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=',