Message ID | 20190503111832.30316-4-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Series | [PULL,v2,01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf | expand |
diff --git a/CODING_STYLE b/CODING_STYLE index 90321e9c2821..cb8edcbb3692 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=',